-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct permissions for dictionaries #72051
Merged
alexey-milovidov
merged 3 commits into
master
from
corrent_permissions_for_dictionaries
Nov 19, 2024
Merged
Correct permissions for dictionaries #72051
alexey-milovidov
merged 3 commits into
master
from
corrent_permissions_for_dictionaries
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitamikhaylov
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
Nov 18, 2024
robot-ch-test-poll4
added
the
pr-improvement
Pull request with some product improvements
label
Nov 18, 2024
Contributor
This is an automated comment for commit 36902c6 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
alexey-milovidov
approved these changes
Nov 19, 2024
robot-ch-test-poll3
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Nov 19, 2024
This was referenced Nov 19, 2024
robot-ch-test-poll
added a commit
that referenced
this pull request
Nov 19, 2024
Cherry pick #72051 to 24.8: Correct permissions for dictionaries
robot-clickhouse
added a commit
that referenced
this pull request
Nov 19, 2024
This was referenced Nov 19, 2024
robot-ch-test-poll
added a commit
that referenced
this pull request
Nov 19, 2024
Cherry pick #72051 to 24.9: Correct permissions for dictionaries
robot-clickhouse
added a commit
that referenced
this pull request
Nov 19, 2024
This was referenced Nov 19, 2024
robot-ch-test-poll
added a commit
that referenced
this pull request
Nov 19, 2024
Cherry pick #72051 to 24.10: Correct permissions for dictionaries
robot-clickhouse
added a commit
that referenced
this pull request
Nov 19, 2024
robot-ch-test-poll3
added a commit
that referenced
this pull request
Nov 19, 2024
Backport #72051 to 24.10: Correct permissions for dictionaries
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Nov 19, 2024
Backport #72051 to 24.8: Correct permissions for dictionaries
nikitamikhaylov
added a commit
that referenced
this pull request
Nov 19, 2024
Backport #72051 to 24.9: Correct permissions for dictionaries
robot-clickhouse-ci-2
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-improvement
Pull request with some product improvements
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
When retrieving data directly from a dictionary using Dictionary storage, dictionary table function, or direct SELECT from the dictionary itself, it is now enough to have
SELECT
permission ordictGet
permission for the dictionary. This aligns with previous attempts to prevent ACL bypasses: #57362 and #65359. It also makes the latter one backward compatible.Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing):