Merge pull request #150 from ClickHouse/fix/proto-datetime-overflow

fix(proto): fix DateTime overflow
ClickHouse · Jul 7, 2022 · 4d7f017 · 4d7f017
2 parents d5f2158 + a81a32e
commit 4d7f017
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/proto/datetime.go b/proto/datetime.go
@@ -3,7 +3,7 @@ package proto
 import "time"
 
 // DateTime represents DateTime type.
-type DateTime int32
+type DateTime uint32
 
 // ToDateTime converts time.Time to DateTime.
 func ToDateTime(t time.Time) DateTime {

diff --git a/query_test.go b/query_test.go
@@ -26,6 +26,22 @@ func requireEqual[T any](t *testing.T, a, b proto.ColumnOf[T]) {
 	}
 }
 
+func TestDateTimeOverflow(t *testing.T) {
+	t.Parallel()
+	ctx := context.Background()
+	conn := Conn(t)
+	var data proto.ColDateTime
+	query := Query{
+		Body: "SELECT toDateTime('2061-02-01 00:00:00') as v",
+		Result: proto.Results{
+			{Name: "v", Data: &data},
+		},
+	}
+	require.NoError(t, conn.Do(ctx, query))
+	require.Equal(t, 1, data.Rows())
+	require.Equal(t, "2061-02-01 00:00:00", data.Row(0).Format("2006-01-02 15:04:05"))
+}
+
 func TestClient_Query(t *testing.T) {
 	ctx := context.Background()
 	t.Parallel()