Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move module #118

Merged
merged 1 commit into from
Jun 10, 2022
Merged

refactor: move module #118

merged 1 commit into from
Jun 10, 2022

Conversation

ernado
Copy link
Collaborator

@ernado ernado commented Jun 9, 2022

cc: @gingerwizard

move to github.com/ClickHouse/ch-go, so repo name should be ch-go

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #118 (c206f12) into main (8f8a51c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head c206f12 differs from pull request most recent head 0ffbb18. Consider uploading reports for the commit 0ffbb18 to get more accurate results

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   77.77%   77.81%   +0.03%     
==========================================
  Files         124      124              
  Lines        5800     5810      +10     
==========================================
+ Hits         4511     4521      +10     
  Misses       1065     1065              
  Partials      224      224              
Impacted Files Coverage Δ
chpool/client.go 82.35% <ø> (ø)
chpool/conn.go 72.72% <ø> (ø)
chpool/pool.go 60.52% <ø> (ø)
cht/cht.go 90.12% <ø> (ø)
client.go 72.82% <ø> (ø)
handshake.go 61.53% <ø> (ø)
otelch/version.go 100.00% <ø> (ø)
ping.go 27.27% <ø> (ø)
proto/reader.go 78.16% <ø> (ø)
query.go 66.10% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8a51c...0ffbb18. Read the comment docs.

@ernado
Copy link
Collaborator Author

ernado commented Jun 9, 2022

Or probably ch-go instead of go-ch
Naming is hard :(

@ernado ernado marked this pull request as ready for review June 10, 2022 10:03
@ernado ernado merged commit 7d9ab13 into main Jun 10, 2022
@ernado ernado deleted the reafactor/move branch June 10, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant