Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proto): implement Interval and Nothing #135

Merged
merged 6 commits into from
Jun 19, 2022
Merged

feat(proto): implement Interval and Nothing #135

merged 6 commits into from
Jun 19, 2022

Conversation

ernado
Copy link
Collaborator

@ernado ernado commented Jun 19, 2022

Ref: #120

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2022

Codecov Report

Merging #135 (92595c4) into main (a62ef09) will decrease coverage by 0.22%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   76.02%   75.80%   -0.23%     
==========================================
  Files         120      122       +2     
  Lines        5710     5782      +72     
==========================================
+ Hits         4341     4383      +42     
- Misses       1164     1189      +25     
- Partials      205      210       +5     
Impacted Files Coverage Δ
cht/config.go 57.14% <ø> (ø)
proto/column.go 78.94% <ø> (ø)
proto/col_interval.go 53.12% <53.12%> (ø)
proto/col_nothing.go 76.92% <76.92%> (ø)
proto/col_auto.go 73.49% <78.57%> (+1.03%) ⬆️
client.go 72.82% <0.00%> (-1.05%) ⬇️
query.go 66.10% <0.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62ef09...92595c4. Read the comment docs.

@ernado ernado merged commit 1680f44 into main Jun 19, 2022
@ernado ernado deleted the feat/types branch June 19, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants