Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proto): improve IPv6 column speed #17

Merged
merged 3 commits into from
Jan 6, 2022
Merged

feat(proto): improve IPv6 column speed #17

merged 3 commits into from
Jan 6, 2022

Conversation

ernado
Copy link
Collaborator

@ernado ernado commented Jan 6, 2022

name                     old time/op    new time/op     delta
ColIPv6_DecodeColumn-32    2.72µs ± 3%     0.49µs ± 3%   -82.08%  (p=0.008 n=5+5)
ColIPv6_EncodeColumn-32    2.27µs ± 3%     0.22µs ± 3%   -90.10%  (p=0.008 n=5+5)

name                     old speed      new speed       delta
ColIPv6_DecodeColumn-32  5.88GB/s ± 3%  32.85GB/s ± 3%  +458.15%  (p=0.008 n=5+5)
ColIPv6_EncodeColumn-32  7.04GB/s ± 3%  71.13GB/s ± 3%  +910.20%  (p=0.008 n=5+5)

With purego:

name                     old time/op    new time/op     delta
ColIPv6_DecodeColumn-32    2.74µs ± 1%     1.78µs ± 4%  -34.99%  (p=0.008 n=5+5)
ColIPv6_EncodeColumn-32    2.31µs ± 8%     1.39µs ± 1%  -39.89%  (p=0.008 n=5+5)

name                     old speed      new speed       delta
ColIPv6_DecodeColumn-32  5.85GB/s ± 1%   9.00GB/s ± 5%  +53.91%  (p=0.008 n=5+5)
ColIPv6_EncodeColumn-32  6.95GB/s ± 7%  11.54GB/s ± 1%  +66.11%  (p=0.008 n=5+5)

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #17 (fd47dd1) into main (69a2fcf) will decrease coverage by 0.18%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   79.37%   79.18%   -0.19%     
==========================================
  Files         105      105              
  Lines        4256     4233      -23     
==========================================
- Hits         3378     3352      -26     
- Misses        709      711       +2     
- Partials      169      170       +1     
Impacted Files Coverage Δ
proto/col_ipv6_unsafe_gen.go 88.88% <88.88%> (ø)
proto/ipv6.go 100.00% <100.00%> (ø)
proto/col_ipv6_safe_gen.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a2fcf...fd47dd1. Read the comment docs.

@ernado ernado merged commit f323d41 into main Jan 6, 2022
@ernado ernado deleted the feat/speedup-ipv6 branch January 6, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant