Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): add with totals case (issue #382) #384

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix(query): add with totals case (issue #382) #384

merged 1 commit into from
Feb 22, 2024

Conversation

yehonatanwe
Copy link
Contributor

Summary

A suggestion on how to resolve #382 (comment)
With these changes, the totals row will be returned as the last row of the result.

Checklist

  • [V] Unit and integration tests covering the common scenarios were added
  • [V] A human-readable description of the changes was provided to include in CHANGELOG

@ernado ernado merged commit db4dad6 into ClickHouse:main Feb 22, 2024
23 checks passed
@yehonatanwe yehonatanwe deleted the group_by_with_totals branch February 22, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

group by with totals fails with 'handle packet: unexpected packet "Totals"'
2 participants