Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Block stream read process would be terminated by empty block with zero rows #1104

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Fix: Block stream read process would be terminated by empty block with zero rows #1104

merged 2 commits into from
Oct 3, 2023

Conversation

crisismaple
Copy link
Contributor

@crisismaple crisismaple commented Sep 25, 2023 •
edited
Loading

Summary

Currently, empty row blocks will terminate block stream reading (i.e. rows.Next() == false ), this was caused by the fall through row count increase logic after block reset.

Checklist

  • Unit and integration tests covering the common scenarios were added

@crisismaple crisismaple changed the title support skip empty block while reading rows from stream Fix: Skip empty block while reading rows from block stream Sep 25, 2023
@crisismaple crisismaple changed the title Fix: Skip empty block while reading rows from block stream Fix: Block stream read process would be terminated by empty block with zero rows Sep 26, 2023
jkaflik
jkaflik approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @crisismaple . Much appreciated work.

@jkaflik jkaflik merged commit 7d2211d into ClickHouse:main Oct 3, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaflik jkaflik jkaflik approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisismaple @jkaflik