Fix panic on format nil *fmt.Stringer type value #1200
Merged
+89
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This comment was marked as outdated.
This comment was marked as outdated.
zaneli
changed the title
*fmt.Stringer value
zaneli
commented
Feb 25, 2024
| if v := reflect.ValueOf(v); v.Kind() == reflect.Pointer && | ||
| v.IsNil() && | ||
| v.Type().Elem().Implements(reflect.TypeOf((*fmt.Stringer)(nil)).Elem()) { | ||
| return "NULL", nil |
There was a problem hiding this comment.
I made a similar check using database/sql as a reference.
This implementation is also copied go-sql-driver/mysql.
Should I write a source code comment mentioning the reference source?
zaneli
commented
Feb 26, 2024
| }, | ||
| { | ||
| name: "fmt.Stringer implemented struct typed-nil value", | ||
| value: (*Test1200NullStr)(nil), |
There was a problem hiding this comment.
Currently, panic this case.
--- FAIL: Test1200 (0.03s)
--- FAIL: Test1200/fmt.Stringer_implemented_struct_typed-nil_value (0.00s)
panic: value method github.com/ClickHouse/clickhouse-go/v2/tests/issues.Test1200NullStr.String called using nil *Test1200NullStr pointer [recovered]
panic: value method github.com/ClickHouse/clickhouse-go/v2/tests/issues.Test1200NullStr.String called using nil *Test1200NullStr pointer
goroutine 188 [running]:
testing.tRunner.func1.2({0x10084d7a0, 0xc0001ae200})
/Users/zaneli/sdk/go1.21.1/src/testing/testing.go:1545 +0x238
testing.tRunner.func1()
/Users/zaneli/sdk/go1.21.1/src/testing/testing.go:1548 +0x397
panic({0x10084d7a0?, 0xc0001ae200?})
/Users/zaneli/sdk/go1.21.1/src/runtime/panic.go:914 +0x21f
github.com/ClickHouse/clickhouse-go/v2/tests/issues.(*Test1200NullStr).String(0xc00008a958?)
<autogenerated>:1 +0x25
github.com/ClickHouse/clickhouse-go/v2.format(0x1010c8680?, 0x60?, {0x100839d60?, 0x0?})
/Users/zaneli/go/src/github.com/zaneli/clickhouse-go/bind.go:309 +0x62e
github.com/ClickHouse/clickhouse-go/v2.bindPositional(0x0?, {0x1009644b4, 0x32}, {0xc0000d6160, 0x2, 0x0?})
/Users/zaneli/go/src/github.com/zaneli/clickhouse-go/bind.go:144 +0x2d4
github.com/ClickHouse/clickhouse-go/v2.bind(0x0?, {0x1009644b4, 0x32}, {0xc0000d6160?, 0x2, 0x2})
/Users/zaneli/go/src/github.com/zaneli/clickhouse-go/bind.go:93 +0x235
github.com/ClickHouse/clickhouse-go/v2.bindQueryOrAppendParameters(0x0?, 0xc00008ad58?, {0x1009644b4?, 0x32?}, 0x0?, {0xc0000d6160?, 0x2?, 0x2?})
/Users/zaneli/go/src/github.com/zaneli/clickhouse-go/query_parameters.go:59 +0x16e
github.com/ClickHouse/clickhouse-go/v2.(*connect).exec(0xc000512000, {0x100ac6c00, 0x1010c8680}, {0x1009644b4, 0x32}, {0xc0000d6160, 0x2, 0x2})
/Users/zaneli/go/src/github.com/zaneli/clickhouse-go/conn_exec.go:30 +0x105
github.com/ClickHouse/clickhouse-go/v2.(*clickhouse).Exec(0x5ad?, {0x100ac6c00, 0x1010c8680}, {0x1009644b4, 0x32}, {0xc0000d6160, 0x2, 0x2})
/Users/zaneli/go/src/github.com/zaneli/clickhouse-go/clickhouse.go:149 +0x99
github.com/ClickHouse/clickhouse-go/v2/tests/issues.Test1200.func2(0x1010c8680?)
/Users/zaneli/go/src/github.com/zaneli/clickhouse-go/tests/issues/1200_pr_test.go:61 +0x126
testing.tRunner(0xc000622680, 0xc0003ee4c0)
/Users/zaneli/sdk/go1.21.1/src/testing/testing.go:1595 +0xff
created by testing.(*T).Run in goroutine 185
/Users/zaneli/sdk/go1.21.1/src/testing/testing.go:1648 +0x3ad
jkaflik
approved these changes
Feb 26, 2024
jkaflik
changed the title
*fmt.Stringer value
mx-psi
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Mar 12, 2024
….21.1 (#31065) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://togithub.com/ClickHouse/clickhouse-go) | `v2.17.1` -> `v2.21.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.21.1`](https://togithub.com/ClickHouse/clickhouse-go/releases/tag/v2.21.1) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.21.0...v2.21.1) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Fixes 🐛 - Adds the ability to Append a zero valued time.Time by [@​KevinJoiner](https://togithub.com/KevinJoiner) in [https://github.com/ClickHouse/clickhouse-go/pull/1228](https://togithub.com/ClickHouse/clickhouse-go/pull/1228) #### New Contributors - [@​KevinJoiner](https://togithub.com/KevinJoiner) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1228](https://togithub.com/ClickHouse/clickhouse-go/pull/1228) **Full Changelog**: ClickHouse/clickhouse-go@v2.21.0...v2.21.1 ### [`v2.21.0`](https://togithub.com/ClickHouse/clickhouse-go/releases/tag/v2.21.0) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.20.0...v2.21.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Enhancements 🎉 - Stream HTTP response body read for decompression by [@​rogeryk](https://togithub.com/rogeryk) in [https://github.com/ClickHouse/clickhouse-go/pull/1213](https://togithub.com/ClickHouse/clickhouse-go/pull/1213) ##### Fixes 🐛 - Fix Date32 extremes values handling by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1218](https://togithub.com/ClickHouse/clickhouse-go/pull/1218) - Fix column with double quotes PrepareBatch failed.([#​1216](https://togithub.com/ClickHouse/clickhouse-go/issues/1216)) by [@​YenchangChan](https://togithub.com/YenchangChan) in [https://github.com/ClickHouse/clickhouse-go/pull/1217](https://togithub.com/ClickHouse/clickhouse-go/pull/1217) - Fix an obscure error in HTTP protocol with LZ4 compression by [@​YenchangChan](https://togithub.com/YenchangChan) in [https://github.com/ClickHouse/clickhouse-go/pull/1230](https://togithub.com/ClickHouse/clickhouse-go/pull/1230) ##### Other Changes 🛠 - Replace deprecated `io/ioutil` functions with equivalents by [@​zaneli](https://togithub.com/zaneli) in [https://github.com/ClickHouse/clickhouse-go/pull/1211](https://togithub.com/ClickHouse/clickhouse-go/pull/1211) - Run cloud workflow on main branch only by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1219](https://togithub.com/ClickHouse/clickhouse-go/pull/1219) - ClickHouse 24.2 by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1220](https://togithub.com/ClickHouse/clickhouse-go/pull/1220) **Full Changelog**: ClickHouse/clickhouse-go@v2.20.0...v2.21.0 ### [`v2.20.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2200-2024-02-28----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.19.0...v2.20.0) #### What's Changed ##### Enhancements 🎉 - Support \[n]byte/\[]byte type Scan/Append to FixedString column by [@​rogeryk](https://togithub.com/rogeryk) in [https://github.com/ClickHouse/clickhouse-go/pull/1205](https://togithub.com/ClickHouse/clickhouse-go/pull/1205) ##### Other Changes 🛠 - Enable cloud tests by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1202](https://togithub.com/ClickHouse/clickhouse-go/pull/1202) - Removed LowCardinality(UInt64) tests that caused allow_suspicious_low_cardinality_types related error by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1206](https://togithub.com/ClickHouse/clickhouse-go/pull/1206) **Full Changelog**: ClickHouse/clickhouse-go@v2.19.0...v2.20.0 ### [`v2.19.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2190-2024-02-26----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.18.0...v2.19.0) #### What's Changed ##### Enhancements 🎉 - handle ctx.Done() in acquire by [@​threadedstream](https://togithub.com/threadedstream) in [https://github.com/ClickHouse/clickhouse-go/pull/1199](https://togithub.com/ClickHouse/clickhouse-go/pull/1199) ##### Fixes 🐛 - Fix panic on format nil \*fmt.Stringer type value by [@​zaneli](https://togithub.com/zaneli) in [https://github.com/ClickHouse/clickhouse-go/pull/1200](https://togithub.com/ClickHouse/clickhouse-go/pull/1200) ##### Other Changes 🛠 - Update Go/ClickHouse versions by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1201](https://togithub.com/ClickHouse/clickhouse-go/pull/1201) #### New Contributors - [@​threadedstream](https://togithub.com/threadedstream) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1199](https://togithub.com/ClickHouse/clickhouse-go/pull/1199) - [@​zaneli](https://togithub.com/zaneli) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1200](https://togithub.com/ClickHouse/clickhouse-go/pull/1200) **Full Changelog**: ClickHouse/clickhouse-go@v2.18.0...v2.19.0 ### [`v2.18.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2180-2024-02-01----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.17.1...v2.18.0) #### What's Changed ##### Enhancements 🎉 - Add WithAllocBufferColStrProvider string column allocator for batch insert performance boost by [@​hongker](https://togithub.com/hongker) in [https://github.com/ClickHouse/clickhouse-go/pull/1181](https://togithub.com/ClickHouse/clickhouse-go/pull/1181) ##### Fixes 🐛 - Fix bind for seconds scale DateTime by [@​jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1184](https://togithub.com/ClickHouse/clickhouse-go/pull/1184) ##### Other Changes 🛠 - resolves [#​1163](https://togithub.com/ClickHouse/clickhouse-go/issues/1163) debugF function is not respected by [@​omurbekjk](https://togithub.com/omurbekjk) in [https://github.com/ClickHouse/clickhouse-go/pull/1166](https://togithub.com/ClickHouse/clickhouse-go/pull/1166) #### New Contributors - [@​omurbekjk](https://togithub.com/omurbekjk) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1166](https://togithub.com/ClickHouse/clickhouse-go/pull/1166) - [@​hongker](https://togithub.com/hongker) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1181](https://togithub.com/ClickHouse/clickhouse-go/pull/1181) **Full Changelog**: ClickHouse/clickhouse-go@v2.17.1...v2.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzOC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
DougManton
referenced
this pull request
in DougManton/opentelemetry-collector-contrib
Mar 13, 2024
….21.1 (open-telemetry#31065) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://togithub.com/ClickHouse/clickhouse-go) | `v2.17.1` -> `v2.21.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.21.1`](https://togithub.com/ClickHouse/clickhouse-go/releases/tag/v2.21.1) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.21.0...v2.21.1) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Fixes 🐛 - Adds the ability to Append a zero valued time.Time by [@&open-telemetry#8203;KevinJoiner](https://togithub.com/KevinJoiner) in [https://github.com/ClickHouse/clickhouse-go/pull/1228](https://togithub.com/ClickHouse/clickhouse-go/pull/1228) #### New Contributors - [@&open-telemetry#8203;KevinJoiner](https://togithub.com/KevinJoiner) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1228](https://togithub.com/ClickHouse/clickhouse-go/pull/1228) **Full Changelog**: ClickHouse/clickhouse-go@v2.21.0...v2.21.1 ### [`v2.21.0`](https://togithub.com/ClickHouse/clickhouse-go/releases/tag/v2.21.0) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.20.0...v2.21.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Enhancements 🎉 - Stream HTTP response body read for decompression by [@&open-telemetry#8203;rogeryk](https://togithub.com/rogeryk) in [https://github.com/ClickHouse/clickhouse-go/pull/1213](https://togithub.com/ClickHouse/clickhouse-go/pull/1213) ##### Fixes 🐛 - Fix Date32 extremes values handling by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1218](https://togithub.com/ClickHouse/clickhouse-go/pull/1218) - Fix column with double quotes PrepareBatch failed.([#&open-telemetry#8203;1216](https://togithub.com/ClickHouse/clickhouse-go/issues/1216)) by [@&open-telemetry#8203;YenchangChan](https://togithub.com/YenchangChan) in [https://github.com/ClickHouse/clickhouse-go/pull/1217](https://togithub.com/ClickHouse/clickhouse-go/pull/1217) - Fix an obscure error in HTTP protocol with LZ4 compression by [@&open-telemetry#8203;YenchangChan](https://togithub.com/YenchangChan) in [https://github.com/ClickHouse/clickhouse-go/pull/1230](https://togithub.com/ClickHouse/clickhouse-go/pull/1230) ##### Other Changes 🛠 - Replace deprecated `io/ioutil` functions with equivalents by [@&open-telemetry#8203;zaneli](https://togithub.com/zaneli) in [https://github.com/ClickHouse/clickhouse-go/pull/1211](https://togithub.com/ClickHouse/clickhouse-go/pull/1211) - Run cloud workflow on main branch only by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1219](https://togithub.com/ClickHouse/clickhouse-go/pull/1219) - ClickHouse 24.2 by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1220](https://togithub.com/ClickHouse/clickhouse-go/pull/1220) **Full Changelog**: ClickHouse/clickhouse-go@v2.20.0...v2.21.0 ### [`v2.20.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2200-2024-02-28----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.19.0...v2.20.0) #### What's Changed ##### Enhancements 🎉 - Support \[n]byte/\[]byte type Scan/Append to FixedString column by [@&open-telemetry#8203;rogeryk](https://togithub.com/rogeryk) in [https://github.com/ClickHouse/clickhouse-go/pull/1205](https://togithub.com/ClickHouse/clickhouse-go/pull/1205) ##### Other Changes 🛠 - Enable cloud tests by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1202](https://togithub.com/ClickHouse/clickhouse-go/pull/1202) - Removed LowCardinality(UInt64) tests that caused allow_suspicious_low_cardinality_types related error by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1206](https://togithub.com/ClickHouse/clickhouse-go/pull/1206) **Full Changelog**: ClickHouse/clickhouse-go@v2.19.0...v2.20.0 ### [`v2.19.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2190-2024-02-26----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.18.0...v2.19.0) #### What's Changed ##### Enhancements 🎉 - handle ctx.Done() in acquire by [@&open-telemetry#8203;threadedstream](https://togithub.com/threadedstream) in [https://github.com/ClickHouse/clickhouse-go/pull/1199](https://togithub.com/ClickHouse/clickhouse-go/pull/1199) ##### Fixes 🐛 - Fix panic on format nil \*fmt.Stringer type value by [@&open-telemetry#8203;zaneli](https://togithub.com/zaneli) in [https://github.com/ClickHouse/clickhouse-go/pull/1200](https://togithub.com/ClickHouse/clickhouse-go/pull/1200) ##### Other Changes 🛠 - Update Go/ClickHouse versions by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1201](https://togithub.com/ClickHouse/clickhouse-go/pull/1201) #### New Contributors - [@&open-telemetry#8203;threadedstream](https://togithub.com/threadedstream) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1199](https://togithub.com/ClickHouse/clickhouse-go/pull/1199) - [@&open-telemetry#8203;zaneli](https://togithub.com/zaneli) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1200](https://togithub.com/ClickHouse/clickhouse-go/pull/1200) **Full Changelog**: ClickHouse/clickhouse-go@v2.18.0...v2.19.0 ### [`v2.18.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2180-2024-02-01----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.17.1...v2.18.0) #### What's Changed ##### Enhancements 🎉 - Add WithAllocBufferColStrProvider string column allocator for batch insert performance boost by [@&open-telemetry#8203;hongker](https://togithub.com/hongker) in [https://github.com/ClickHouse/clickhouse-go/pull/1181](https://togithub.com/ClickHouse/clickhouse-go/pull/1181) ##### Fixes 🐛 - Fix bind for seconds scale DateTime by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1184](https://togithub.com/ClickHouse/clickhouse-go/pull/1184) ##### Other Changes 🛠 - resolves [#&open-telemetry#8203;1163](https://togithub.com/ClickHouse/clickhouse-go/issues/1163) debugF function is not respected by [@&open-telemetry#8203;omurbekjk](https://togithub.com/omurbekjk) in [https://github.com/ClickHouse/clickhouse-go/pull/1166](https://togithub.com/ClickHouse/clickhouse-go/pull/1166) #### New Contributors - [@&open-telemetry#8203;omurbekjk](https://togithub.com/omurbekjk) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1166](https://togithub.com/ClickHouse/clickhouse-go/pull/1166) - [@&open-telemetry#8203;hongker](https://togithub.com/hongker) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1181](https://togithub.com/ClickHouse/clickhouse-go/pull/1181) **Full Changelog**: ClickHouse/clickhouse-go@v2.17.1...v2.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzOC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
XinRanZhAWS
referenced
this pull request
in XinRanZhAWS/opentelemetry-collector-contrib
Mar 13, 2024
](https://renovatebot.com){kind=link}
….21.1 (open-telemetry#31065) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://togithub.com/ClickHouse/clickhouse-go) | `v2.17.1` -> `v2.21.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.21.1`](https://togithub.com/ClickHouse/clickhouse-go/releases/tag/v2.21.1) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.21.0...v2.21.1) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Fixes 🐛 - Adds the ability to Append a zero valued time.Time by [@&open-telemetry#8203;KevinJoiner](https://togithub.com/KevinJoiner) in [https://github.com/ClickHouse/clickhouse-go/pull/1228](https://togithub.com/ClickHouse/clickhouse-go/pull/1228) #### New Contributors - [@&open-telemetry#8203;KevinJoiner](https://togithub.com/KevinJoiner) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1228](https://togithub.com/ClickHouse/clickhouse-go/pull/1228) **Full Changelog**: ClickHouse/clickhouse-go@v2.21.0...v2.21.1 ### [`v2.21.0`](https://togithub.com/ClickHouse/clickhouse-go/releases/tag/v2.21.0) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.20.0...v2.21.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Enhancements 🎉 - Stream HTTP response body read for decompression by [@&open-telemetry#8203;rogeryk](https://togithub.com/rogeryk) in [https://github.com/ClickHouse/clickhouse-go/pull/1213](https://togithub.com/ClickHouse/clickhouse-go/pull/1213) ##### Fixes 🐛 - Fix Date32 extremes values handling by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1218](https://togithub.com/ClickHouse/clickhouse-go/pull/1218) - Fix column with double quotes PrepareBatch failed.([#&open-telemetry#8203;1216](https://togithub.com/ClickHouse/clickhouse-go/issues/1216)) by [@&open-telemetry#8203;YenchangChan](https://togithub.com/YenchangChan) in [https://github.com/ClickHouse/clickhouse-go/pull/1217](https://togithub.com/ClickHouse/clickhouse-go/pull/1217) - Fix an obscure error in HTTP protocol with LZ4 compression by [@&open-telemetry#8203;YenchangChan](https://togithub.com/YenchangChan) in [https://github.com/ClickHouse/clickhouse-go/pull/1230](https://togithub.com/ClickHouse/clickhouse-go/pull/1230) ##### Other Changes 🛠 - Replace deprecated `io/ioutil` functions with equivalents by [@&open-telemetry#8203;zaneli](https://togithub.com/zaneli) in [https://github.com/ClickHouse/clickhouse-go/pull/1211](https://togithub.com/ClickHouse/clickhouse-go/pull/1211) - Run cloud workflow on main branch only by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1219](https://togithub.com/ClickHouse/clickhouse-go/pull/1219) - ClickHouse 24.2 by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1220](https://togithub.com/ClickHouse/clickhouse-go/pull/1220) **Full Changelog**: ClickHouse/clickhouse-go@v2.20.0...v2.21.0 ### [`v2.20.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2200-2024-02-28----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.19.0...v2.20.0) #### What's Changed ##### Enhancements 🎉 - Support \[n]byte/\[]byte type Scan/Append to FixedString column by [@&open-telemetry#8203;rogeryk](https://togithub.com/rogeryk) in [https://github.com/ClickHouse/clickhouse-go/pull/1205](https://togithub.com/ClickHouse/clickhouse-go/pull/1205) ##### Other Changes 🛠 - Enable cloud tests by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1202](https://togithub.com/ClickHouse/clickhouse-go/pull/1202) - Removed LowCardinality(UInt64) tests that caused allow_suspicious_low_cardinality_types related error by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1206](https://togithub.com/ClickHouse/clickhouse-go/pull/1206) **Full Changelog**: ClickHouse/clickhouse-go@v2.19.0...v2.20.0 ### [`v2.19.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2190-2024-02-26----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.18.0...v2.19.0) #### What's Changed ##### Enhancements 🎉 - handle ctx.Done() in acquire by [@&open-telemetry#8203;threadedstream](https://togithub.com/threadedstream) in [https://github.com/ClickHouse/clickhouse-go/pull/1199](https://togithub.com/ClickHouse/clickhouse-go/pull/1199) ##### Fixes 🐛 - Fix panic on format nil \*fmt.Stringer type value by [@&open-telemetry#8203;zaneli](https://togithub.com/zaneli) in [https://github.com/ClickHouse/clickhouse-go/pull/1200](https://togithub.com/ClickHouse/clickhouse-go/pull/1200) ##### Other Changes 🛠 - Update Go/ClickHouse versions by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1201](https://togithub.com/ClickHouse/clickhouse-go/pull/1201) #### New Contributors - [@&open-telemetry#8203;threadedstream](https://togithub.com/threadedstream) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1199](https://togithub.com/ClickHouse/clickhouse-go/pull/1199) - [@&open-telemetry#8203;zaneli](https://togithub.com/zaneli) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1200](https://togithub.com/ClickHouse/clickhouse-go/pull/1200) **Full Changelog**: ClickHouse/clickhouse-go@v2.18.0...v2.19.0 ### [`v2.18.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2180-2024-02-01----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.17.1...v2.18.0) #### What's Changed ##### Enhancements 🎉 - Add WithAllocBufferColStrProvider string column allocator for batch insert performance boost by [@&open-telemetry#8203;hongker](https://togithub.com/hongker) in [https://github.com/ClickHouse/clickhouse-go/pull/1181](https://togithub.com/ClickHouse/clickhouse-go/pull/1181) ##### Fixes 🐛 - Fix bind for seconds scale DateTime by [@&open-telemetry#8203;jkaflik](https://togithub.com/jkaflik) in [https://github.com/ClickHouse/clickhouse-go/pull/1184](https://togithub.com/ClickHouse/clickhouse-go/pull/1184) ##### Other Changes 🛠 - resolves [#&open-telemetry#8203;1163](https://togithub.com/ClickHouse/clickhouse-go/issues/1163) debugF function is not respected by [@&open-telemetry#8203;omurbekjk](https://togithub.com/omurbekjk) in [https://github.com/ClickHouse/clickhouse-go/pull/1166](https://togithub.com/ClickHouse/clickhouse-go/pull/1166) #### New Contributors - [@&open-telemetry#8203;omurbekjk](https://togithub.com/omurbekjk) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1166](https://togithub.com/ClickHouse/clickhouse-go/pull/1166) - [@&open-telemetry#8203;hongker](https://togithub.com/hongker) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1181](https://togithub.com/ClickHouse/clickhouse-go/pull/1181) **Full Changelog**: ClickHouse/clickhouse-go@v2.17.1...v2.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzOC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, if the pointer to the struct that implements
fmt.Stringeris nil, the bind method will panic.This PR fixes that.
Checklist
Delete items not relevant to your PR:
[ ] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials