Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check version + decode compressed errors over HTTP #792

Merged
merged 6 commits into from
Oct 20, 2022
Merged

Check version + decode compressed errors over HTTP #792

merged 6 commits into from
Oct 20, 2022

Conversation

gingerwizard
Copy link
Collaborator

@gingerwizard gingerwizard commented Oct 20, 2022 •
edited
Loading

Closes #727

Addresses two issues:

  1. Prints an error and warns the user if the client is an unsupported version @Ryado.
  2. Ensures errors are decompressed on HTTP - previously, if they were lz4 or zstd they wouldn't be decompressed and users would get a poor error.

@gingerwizard gingerwizard requested a review from genzgd October 20, 2022 15:15
@gingerwizard gingerwizard self-assigned this Oct 20, 2022
@gingerwizard gingerwizard mentioned this pull request Oct 20, 2022
Closed
@gingerwizard gingerwizard merged commit b92bc86 into main Oct 20, 2022
@gingerwizard gingerwizard deleted the embed_version branch October 20, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genzgd genzgd genzgd approved these changes

Assignees

@gingerwizard gingerwizard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Safety: error out on unsupported server versions
2 participants
@gingerwizard @genzgd