Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed insert of decimals with non-standard exp representation #909

Merged
merged 2 commits into from
Feb 20, 2023
Merged

fix: fixed insert of decimals with non-standard exp representation #909

merged 2 commits into from
Feb 20, 2023

Conversation

vogrelord
Copy link
Contributor

Summary

Fixed issue when insert of Decimal value 600 ended up with value 6 in database

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vogrelord vogrelord mentioned this pull request Feb 18, 2023
Closed
moming00
moming00 approved these changes Feb 19, 2023
View reviewed changes
Copy link

@moming00 moming00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to me, thx

@jkaflik
Copy link
Contributor

jkaflik commented Feb 19, 2023

@vogrelord thanks for submitting. Will have a look tomorrow morning.
cc @moming00

@jkaflik jkaflik self-assigned this Feb 19, 2023
@jkaflik jkaflik merged commit c399166 into ClickHouse:main Feb 20, 2023
@moming00
Copy link

@jkaflik ，would you mind sharing the release plan?

@jkaflik
Copy link
Contributor

jkaflik commented Feb 20, 2023

@moming00 this will be included in todays release

@moming00
Copy link

@moming00 this will be included in todays release

awesome, thx for that.

@jkaflik
Copy link
Contributor

jkaflik commented Feb 20, 2023 •
edited
Loading

@moming00 here is a release: https://github.com/ClickHouse/clickhouse-go/releases/tag/v2.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moming00 moming00 moming00 approved these changes

Assignees

@jkaflik jkaflik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vogrelord @CLAassistant @jkaflik @moming00