Fix idle connection check for TLS connections #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alekar
approved these changes
Mar 29, 2023
kgoralski
approved these changes
Mar 29, 2023
RoryCrispin
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using TLS connection, the idle connection is not correctly checked for liveness. It's because tls.Conn does not implement syscall.Conn which is used to read raw from socket:
https://github.com/ClickHouse/clickhouse-go/blob/main/conn_check.go#L31
Add a additional type cast to detect TLS conn and get underlying connection.
Changelog: Fix idle connection liveness check for TLS connections