Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Supporting JPMS #713

Closed
arjenzhou opened this issue Sep 7, 2021 · 4 comments · Fixed by #731, #736 or #740
Closed

[Feature Request] Supporting JPMS #713

arjenzhou opened this issue Sep 7, 2021 · 4 comments · Fixed by #731, #736 or #740
Labels
enhancement module-client Client API and all implementations
Milestone
0.3.2 Release

Comments

@arjenzhou
Copy link

Since Java 9 introduces JPMS, libs without module-info or Automatic module declaration cannot be used after Java 9, is there any plan to support it?
@arjenzhou
Copy link
Author

related discussions:
brettwooldridge/HikariCP#1045
oshi/oshi#1247

arjenzhou added a commit to arjenzhou/clickhouse-jdbc that referenced this issue Sep 7, 2021
@arjenzhou
Supporting JPMS
096fefd 
ClickHouse#713 ClickHouse JDBC support JPMS Automatic Module
@arjenzhou arjenzhou mentioned this issue Sep 7, 2021
Closed
@zhicwu
Copy link
Contributor

zhicwu commented Sep 7, 2021

Thank you @arjenzhou. Yes, we definitely need this.

@zhicwu zhicwu added this to the 0.3.2 Release milestone Sep 7, 2021
@zhicwu zhicwu linked a pull request Oct 6, 2021 that will close this issue
Add repackaged 3rd party libs #731
Merged
@zhicwu
Copy link
Contributor

zhicwu commented Oct 6, 2021

Looks like JPMS is still not widely adopted. Automatic-Module-Name is merely a workaround to make things work the old way. I tried multiple profiles(jre8 & jre11) in Maven, but it's difficult to release multiple jars in one go, not to mention we had to exclude different files in different profiles. As a result, I switched to multi-release jar (JEP#238, which is less flexible but a better way to manage source code and deployment. However, we still have to repackage some third party libraries like RoaringBitmap, gRPC and maybe more :<

@zhicwu zhicwu added the module-client Client API and all implementations label Oct 6, 2021
This was linked to pull requests Oct 7, 2021
New Java client and gRPC support #736
Merged
replace Jackson to Gson #740
Merged
@zhicwu
Copy link
Contributor

zhicwu commented Dec 9, 2021

This has been available since 0.3.2-test1.

In addition to explicit declaration in each module, Automatic-Module-Name was used for shaded jar in case it's needed somewhere.

@zhicwu zhicwu closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement module-client Client API and all implementations
Projects
None yet
Milestone
0.3.2 Release
Development

Successfully merging a pull request may close this issue.

Add repackaged 3rd party libs
New Java client and gRPC support
replace Jackson to Gson
2 participants
@zhicwu @arjenzhou