Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Write time field data loss precision. #1127

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

gaaraG
Copy link
Contributor

@gaaraG gaaraG commented Nov 16, 2022

#1126
The Calendar class's setTime preserves only the millisecond bit and should retain its original precision after the time zone is converted.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Benchmark                                (client)  (connection)  (statement)  (type)   Mode  Cnt    Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-http-jdbc         reuse       normal  object  thrpt   20  221.367 ±  42.926  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc         reuse     prepared  object  thrpt   20  219.748 ±  18.092  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc           new       normal  object  thrpt   20  229.557 ±  23.818  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc           new     prepared  object  thrpt   20  212.719 ±  17.574  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20  251.121 ±  26.725  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20  207.661 ±  18.675  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc           new       normal  object  thrpt   20  254.550 ±  34.802  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc           new     prepared  object  thrpt   20  215.628 ±  18.606  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc         reuse       normal  object  thrpt   20  870.497 ±  77.187  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc         reuse     prepared  object  thrpt   20  912.143 ±  56.386  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc           new       normal  object  thrpt   20  880.728 ± 114.941  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc           new     prepared  object  thrpt   20  885.126 ±  76.254  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20  785.664 ±  46.486  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20  790.067 ±  43.179  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc           new       normal  object  thrpt   20  789.258 ±  80.777  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc           new     prepared  object  thrpt   20  802.634 ±  53.201  ops/s

@zhicwu zhicwu changed the base branch from master to develop November 16, 2022 01:53
@zhicwu
Copy link
Contributor

zhicwu commented Nov 16, 2022

Thanks for your contribution! @gaaraG, could you sign CLA and rebase to develop branch?

@gaaraG
Copy link
Contributor Author

gaaraG commented Nov 16, 2022

Of course.

@zhicwu zhicwu merged commit f588fb1 into ClickHouse:develop Nov 18, 2022
@gaaraG gaaraG deleted the fix-loss-precision branch November 23, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants