Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up code and remove unnecessary dependency #1204

Merged
merged 8 commits into from
Jan 27, 2023
Merged

clean up code and remove unnecessary dependency #1204

merged 8 commits into from
Jan 27, 2023

Conversation

zhicwu
Copy link
Contributor

@zhicwu zhicwu commented Jan 19, 2023 •
edited
Loading

  • verify testDumpFile CI failure in gRPC client (2/3 tests failed)
  • move thread pool to ClickHouseDataStreamFactory along for convenient methods for running blocking task and scheduling a task
  • capture UncheckedIOException from postCloseAction and throw IOException in *Stream.close() method
  • ClickHouseClient.dump & ClickHouseClient.load now support ClickHousePassThruStream

@zhicwu zhicwu marked this pull request as draft January 19, 2023 14:12
@zhicwu zhicwu changed the title re-enable a few tests for gRPC clean up code and remove unnecessary dependency Jan 27, 2023
@zhicwu zhicwu marked this pull request as ready for review January 27, 2023 02:06
@zhicwu zhicwu merged commit b0357a1 into ClickHouse:main Jan 27, 2023
@zhicwu zhicwu mentioned this pull request Jan 27, 2023
Merged
@zhicwu zhicwu mentioned this pull request Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhicwu