Copy timezone from response if differs from config server_time_zone #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slvrtrn
reviewed
Jul 23, 2024
| Assert.assertTrue(Duration.between(serverTimeNow, nowAtTimezone).abs().getSeconds() < 60, | ||
| "Server time (" + serverTimeNow + " ) should be close to the client time (" + nowAtTimezone + ")"); | ||
| } | ||
| } |
There was a problem hiding this comment.
let's add a daylight saving test as well
Paultagoras
requested changes
Aug 13, 2024
| ZonedDateTime serverNowZoned = rs.getObject(1, ZonedDateTime.class); | ||
|
|
||
|
|
||
| System.out.println("serverNow: " + serverNow + " tzTime: " + tzTime); |
There was a problem hiding this comment.
Do we want these println messages?
There was a problem hiding this comment.
I would like to leave them, but I agree with you - tests should be clean.
There was a problem hiding this comment.
beside no assertions - shame on me
|
Paultagoras
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By default java client will issue a pre-flight
select serverTimezone()when creating a new connection and returned timezone will be used for conversion of returned DateTime values.Server returns its timezone in
X-ClickHouse-Timezoneheader. This timezone is most accurate because it respectssession_timezonesetting. But this header value is not always used what causes double convertion to incorrect value.For example,
select now()returns2024-07-18 20:30:58for server in UTC timezoneselect now() settings session_timezone='America/Los_Angeles'would return2024-07-18 13:30:58andX-ClickHouse-Timezone: America/Los_Angeles.But java client will parse that value into
LocalDateTime [2024-07-18 20:30:58]assuming that server timezone is UTCThis PR makes Client check timezone from the header and override it in config for current query (that config will be used later by deserializer to convert date/time).
Closes #1464
Checklist
Delete items not relevant to your PR: