[client-v2] Add property for network buffer size #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chernser
requested review from
mzitnik and
Paultagoras
and removed request for
mzitnik
|
Paultagoras
approved these changes
Aug 23, 2024
| @@ -181,6 +186,15 @@ private HttpClientConnectionManager poolConnectionManager(SSLContext sslContext, | |||
| connMgrBuilder::setMaxConnPerRoute); | |||
|
|
|||
|
|
|||
| int networkBufferSize = MapUtils.getInt(chConfiguration, "client_network_buffer_size"); | |||
There was a problem hiding this comment.
Should we store the key as a property somewhere?
There was a problem hiding this comment.
yes, we have a story about it.
| @@ -816,6 +829,10 @@ private Map<String, String> setDefaults(Map<String, String> userConfig) { | |||
| userConfig.put("connection_ttl", "-1"); | |||
| } | |||
|
|
|||
| if (!userConfig.containsKey("client_network_buffer_size")) { | |||
There was a problem hiding this comment.
Should this be a property somewhere? In case we need to update it...
There was a problem hiding this comment.
yes, we have a story about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a property to configure a buffer that is used to read data from a socket
Checklist
Delete items not relevant to your PR: