Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Add ability to pass query parameter to queryAll and queryRecords methods. #1979

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Nov 25, 2024

Summary

Closes: #1959

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser requested a review from mzitnik November 25, 2024 22:17
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
32.8% Coverage on New Code (required ≥ 80%)
6.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@chernser chernser changed the title passing query parameters in queryAll and queryRecords [client-v2] Add ability to pass query parameter to queryAll and queryRecords methods. Nov 25, 2024
@chernser chernser merged commit 54da5b6 into main Nov 25, 2024
60 of 61 checks passed
@chernser chernser deleted the v2_params_getRecords branch November 25, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[client-v2] Passing server parameters with queryRecords method
2 participants