Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client-v2] Do not close provided executor #2088

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[client-v2] Do not close provided executor #2088

merged 1 commit into from
Jan 15, 2025

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Jan 15, 2025 •
edited
Loading

Summary

Do not close provided executor on Client#close()

Checklist

Delete items not relevant to your PR:

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chernser chernser merged commit 952a945 into main Jan 15, 2025
30 checks passed
@chernser chernser deleted the v2_shared_executor branch January 15, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzitnik mzitnik mzitnik approved these changes

@Paultagoras Paultagoras Paultagoras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chernser @mzitnik @Paultagoras