Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the addBatch method, add parsedStmt.hasValues() check to ensure that the query of the form 'INSERT INTO ... SELECT' will be executed #655

Merged
merged 2 commits into from
May 10, 2021

Conversation

SharpRay
Copy link

In the addBatch method, add parsedStmt.hasValues() check to ensure that the query of the form 'INSERT INTO ... SELECT' will be executed.

zhicwu and others added 2 commits April 28, 2021 00:11
…at the query of the form 'INSERT INTO ... SELECT' will be executed
@github-actions
Copy link

Benchmark                           (client)  (statement)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-jdbc       normal  thrpt   20   262.450 ±  30.137  ops/s
Basic.insertOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20   257.053 ±  27.227  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc       normal  thrpt   20  1195.093 ± 109.590  ops/s
Basic.selectOneRandomNumber  clickhouse-jdbc     prepared  thrpt   20  1175.939 ± 138.396  ops/s

@zhicwu zhicwu changed the base branch from master to develop May 10, 2021 08:37
@zhicwu
Copy link
Contributor

zhicwu commented May 10, 2021

Thank you @SharpRay. Just wrote a test case to cover this scenario and the fix worked well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants