-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chaos testing #268
Add chaos testing #268
Conversation
Paultagoras
commented
Dec 4, 2023
- Merged ExactlyOnce and Integration tests
- Includes refactoring some code (or making code reusable)
- Modified to support GitHub actions
- Adding in a proxy in between certain steps
- Adjusting test cases
- Removed some redundant tests
- Added Github Action
…GitHub actions, adding in a proxy in between certain steps, adjusting test cases, removed some redundant cases, added Github Action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very big PR.
If the files that were deleted and created the same (Why them did not moved)
- name: Setup and execute Gradle 'integrationTest' task | ||
uses: gradle/gradle-build-action@v2 | ||
with: | ||
arguments: integrationTest --info -D clickhouse.host="${{vars.CLICKHOUSE_HOST}}" -D clickhouse.port="${{vars.CLICKHOUSE_PORT}}" -D clickhouse.password="${{secrets.CLICKHOUSE_PASSWORD}}" -D clickhouse.cloud.organization="${{vars.CLICKHOUSE_CLOUD_ORGANIZATION}}" -D clickhouse.cloud.id="${{vars.CLICKHOUSE_CLOUD_ID}}" -D clickhouse.cloud.secret="${{secrets.CLICKHOUSE_CLOUD_SECRET}}" -D clickhouse.cloud.serviceId="${{vars.CLICKHOUSE_CLOUD_SERVICE_ID}}" -D clickhouse.cloud.host="${{vars.CLICKHOUSE_CLOUD_API_HOST}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have added integration tests how long it take to run them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think last time it took 45 minutes - I'll run them again and see how long it takes. GitHub has a timeout of 6 hours apparently so we should be ok from that perspective (it's still a while, but with manual triggering it shouldn't block us solving an issue if needed and still allows us to verify if needed)
Technically I rewrote several lines of code from it (enough that it apparently didn't identify them as moved) - partly it was cleaning up existing stuff, partly it was tweaking it to work differently, refactoring redundant code, etc... |