Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim excess fields #469

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Trim excess fields #469

merged 3 commits into from
Nov 14, 2024

Conversation

Paultagoras
Copy link
Contributor

This should help reduce the payload size, if there is a lot of data being sent to Kafka but only a limited number of fields in the table itself.

@Paultagoras Paultagoras requested a review from mzitnik November 14, 2024 02:01
@Paultagoras Paultagoras self-assigned this Nov 14, 2024
Copy link
Collaborator

@mzitnik mzitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test?
Going forward i would like us to convert it to RawBinary (and not send it as json - this should also take care of not sending unnecessary data)

@Paultagoras
Copy link
Contributor Author

Do we have a test? Going forward i would like us to convert it to RawBinary (and not send it as json - this should also take care of not sending unnecessary data)

I'd love to add insert(Map) to the v2 client and use that... 😉

@Paultagoras Paultagoras merged commit 556c2bb into main Nov 14, 2024
6 of 8 checks passed
@Paultagoras Paultagoras deleted the trim-excess-fields branch November 14, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants