Tuple testing & Nullable fields in Tuple support #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paultagoras
approved these changes
Jan 15, 2025
Paultagoras
reviewed
Jan 15, 2025
src/main/java/com/clickhouse/kafka/connect/sink/db/ClickHouseWriter.java
Outdated
Show resolved
Hide resolved
…not need to add the default marker
mshustov
reviewed
Jan 16, 2025
src/test/java/com/clickhouse/kafka/connect/sink/ClickHouseSinkTaskWithSchemaTest.java
Show resolved
Hide resolved
bcwalrus
reviewed
Jan 16, 2025
| @@ -622,7 +622,7 @@ protected void doWritePrimitive(Type columnType, Schema.Type dataType, OutputStr | |||
| } | |||
|
|
|||
|
|
|||
| protected void doWriteCol(Data value, boolean fieldExists, Column col, OutputStream stream, boolean defaultsSupport) throws IOException { | |||
| protected void doWriteCol(Data value, boolean fieldExists, Column col, OutputStream stream, boolean defaultsSupport, boolean firstTime) throws IOException { | |||
There was a problem hiding this comment.
We probably don't need firstTime.
- All we care about is whether the default prefix byte applies to this col. And that's already captured by
defaultsSupport. So maybe we should reuse that? - Btw, the name could be more descriptive, like
isRootCol.
Maybe also add a comment, something like:
RowBinaryWithDefaults writes an extra byte 01 to indicate default, and 00
to indicate actual value. But that only applies to top level columns.
| @@ -479,7 +479,7 @@ protected void doWriteColValue(Column col, OutputStream stream, Data value, bool | |||
| Data innerData = (Data) jsonMapValues.get(fieldName); | |||
| try { | |||
| // we need to apply here the default and nullable logic | |||
| doWriteCol(innerData, jsonMapValues.containsKey(fieldName), column, stream, defaultsSupport); | |||
| doWriteCol(innerData, jsonMapValues.containsKey(fieldName), column, stream, defaultsSupport, false); | |||
There was a problem hiding this comment.
We can just pass in false for defaultsSupport. No need for extra arg. See below.
Paultagoras
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tuple testing & Nullable fields in Tuple support
Checklist
Delete items not relevant to your PR: