Fix issues with the locate function call #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes an issue where the call to the locate function always ignores the `start_pos` parameter. - Fixes an issue where the call to the locate function results in an error when `start_pos` is not specified. - Ensures that the order of arguments remains unchanged during escape sequence replacement. To achieve this, ClickHouse's `position` function has been replaced with ClickHouse's `locate` function, which has the same argument order as the ODBC `locate` function.
mshustov
reviewed
Feb 12, 2025
| // match the type required by `locate`. To avoid the illegal type argument | ||
| // error, we cast the offset parameter to UInt64. The `accurateCast` function | ||
| // ensures that the parameter value is never negative. | ||
| result = "locate(" + needle + "," + haystack + ",accurateCast(" + offset + ",'UInt64'))"; |
slvrtrn
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #466:
start_posparameter.start_posis not specified.Additionally:
positionfunction has been replaced with ClickHouse'slocatefunction, which has the same argument order as the ODBClocatefunction.