Merge pull request #292 from ClickHouse/cloud-tests-against-smt

Cloud tests against smt
ClickHouse · Jun 10, 2024 · f5cc190 · f5cc190
2 parents 506bd18 + fe26a93
commit f5cc190
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 12 deletions.
diff --git a/.github/workflows/test_cloud.yml b/.github/workflows/test_cloud.yml
@@ -8,23 +8,23 @@ on:  # yamllint disable-line rule:truthy
   workflow_dispatch:
 
 jobs:
-  cloud_tests:
-    name: ClickHouse Cloud Tests
+  cloud_smt_tests:
+    name: ClickHouse Cloud SharedMergeTree Tests
     runs-on: ubuntu-latest
 
     env:
       PYTHONPATH: dbt
-      DBT_CH_TEST_HOST: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_HOST }}
-      DBT_CH_TEST_PASSWORD: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD }}
+      DBT_CH_TEST_HOST: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_HOST_SMT }}
+      DBT_CH_TEST_PASSWORD: ${{ secrets.INTEGRATIONS_TEAM_TESTS_CLOUD_PASSWORD_SMT }}
       DBT_CH_TEST_CLUSTER_MODE: true
       DBT_CH_TEST_CLOUD: true
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v3
 
       - name: Setup Python 3.11
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v4
         with:
           python-version: '3.11'
 

diff --git a/dbt/include/clickhouse/macros/materializations/dictionary.sql b/dbt/include/clickhouse/macros/materializations/dictionary.sql
@@ -91,12 +91,6 @@
       {% if credentials.get("database") -%}
       db '{{ credentials.get("database") }}'
       {%- endif %}
-      {% if credentials.get("host") and credentials.get("host") != 'localhost' -%}
-      host '{{ credentials.get("host") }}'
-      {% if credentials.get("port") -%}
-      port '{{ credentials.get("port") }}'
-      {%- endif %}
-      {%- endif %}
       {%- if table is not none %}
         table '{{ table }}'
       {% else %}

diff --git a/tests/integration/adapter/persist_docs/test_persist_docs.py b/tests/integration/adapter/persist_docs/test_persist_docs.py
@@ -179,6 +179,9 @@ def project_config_update(self):
 
     @pytest.fixture(scope="class")
     def run_has_comments(self, project):
+        if os.environ.get('DBT_CH_TEST_CLOUD', '').lower() in ('1', 'true', 'yes'):
+            pytest.skip('Not running comment test for cloud')
+
         def fixt():
             run_dbt()
             run_dbt(["docs", "generate"])