Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve listagg macro #318

Merged
merged 5 commits into from
Jul 16, 2024
Merged

improve listagg macro #318

merged 5 commits into from
Jul 16, 2024

Conversation

igorvoltaic
Copy link
Contributor

Summary

improve listagg macro and add more tests to cover (still need one to cover exception rase)

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@BentsiLeviav BentsiLeviav self-assigned this Jul 15, 2024
@igorvoltaic
Copy link
Contributor Author

Additional tests could be removed if and after this goes in dbt-labs/dbt-core#10445

@dbeatty10 dbeatty10 mentioned this pull request Jul 15, 2024
Closed
3 tasks
@BentsiLeviav BentsiLeviav merged commit 1e62d59 into ClickHouse:main Jul 16, 2024
21 checks passed
@igorvoltaic igorvoltaic deleted the listagg branch July 16, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BentsiLeviav BentsiLeviav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorvoltaic @BentsiLeviav