Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter settings based on Engine #367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shachibista
Copy link

@shachibista shachibista commented Oct 11, 2024

This PR introduces a feature that ignores settings that are not compatible with the Engine. More details in this issue: #366

Checklist

  • A human-readable description of the changes was provided to include in CHANGELOG

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2024

CLA assistant check
All committers have signed the CLA.

@mshustov mshustov requested a review from BentsiLeviav October 29, 2024 12:34
@BentsiLeviav
Copy link
Contributor

Hi @shachibista,

Thank you for your contribution!

I'm hesitant to move forward with this change as it introduces ongoing maintenance requirements. With this setup, every time ClickHouse adds new settings, we’ll need to update the ENGINE_SETTINGS dictionary. Similarly, any new engine additions would also require corresponding updates.

I think the liability is greater than the benefit.

@BentsiLeviav
Copy link
Contributor

@genzgd suggested changing it from a white list to a black list (remove settings we identified as not relevant for this engine), and in case we face a new engine, pass the settings as is.

@shachibista would you mind changing the logic to support this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants