fix: prevent BrokenResourceError by returning structured responses for query errors #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r query errors fixes #25
serprex
approved these changes
Mar 31, 2025
jovezhong
pushed a commit
to jovezhong/mcp-timeplus
that referenced
this pull request
Apr 5, 2025
…r query errors (ClickHouse#26) fixes ClickHouse#25
jovezhong
added a commit
to jovezhong/mcp-timeplus
that referenced
this pull request
Apr 5, 2025
* feat: Add query timeout and thread pool for SELECT queries (ClickHouse#20) * add action to publish to pypi (ClickHouse#19) * add client_name with mcp_clickhouse (ClickHouse#21) * Add descriptions for tools required by Bedrock (ClickHouse#23) Addresses ClickHouse#22 * 0.1.5 * fix: prevent BrokenResourceError by returning structured responses for query errors (ClickHouse#26) fixes ClickHouse#25 * Update README.md - Added link to the Youtube overview (ClickHouse#27) * fix cherry pick issue and add desc * Update publish.yml * change mcp client name --------- Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com> Co-authored-by: Philip Dubé <serprex@users.noreply.github.com> Co-authored-by: Mikhail Shustov <restrry@gmail.com> Co-authored-by: Dmitry Pavlov <pavlovdmst@gmail.com> Co-authored-by: Philip Dubé <philip.dube@clickhouse.com> Co-authored-by: Ryadh DAHIMENE <dahimene.ryadh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25