Skip to content
This repository has been archived by the owner on Feb 10, 2023. It is now read-only.

Do not add default port for requests via proxy (fixes GCS via proxy tunnel usage) #63

Merged
merged 1 commit into from
Jul 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Net/src/HTTPClientSession.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -429,8 +429,13 @@ std::string HTTPClientSession::proxyRequestPrefix() const
{
std::string result("http://");
result.append(_host);
result.append(":");
NumberFormatter::append(result, _port);
/// Do not append default by default, since this may break some servers.
/// One example of such server is GCS (Google Cloud Storage).
if (_port != HTTPSession::HTTP_PORT)
{
result.append(":");
NumberFormatter::append(result, _port);
}
return result;
}

Expand Down
9 changes: 7 additions & 2 deletions NetSSL_OpenSSL/src/HTTPSClientSession.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,13 @@ std::string HTTPSClientSession::proxyRequestPrefix() const
{
std::string result("https://");
result.append(getHost());
result.append(":");
NumberFormatter::append(result, getPort());
/// Do not append default by default, since this may break some servers.
/// One example of such server is GCS (Google Cloud Storage).
if (getPort() != HTTPS_PORT)
{
result.append(":");
NumberFormatter::append(result, getPort());
}
return result;
}

Expand Down