Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The segfault (#58) happens when watch outlives database/cluster. It happens befause
TrxWatch
does not keep any refcount to database/cluster. I fixed the issue by making allFdbFuture
live with eitherTransaction
orDatabase
.I found another possible problem while fixing the issue, which is caused by drop order of Rust. Rust drops struct field from top to bottom[1]. If we define
Cluster
prior toDatabase
, cluster will be dropped beforeDatabase
, which might cause a problem.valgrind
does not complain for this case but I changed the field order to just make sure.[1] https://github.com/rust-lang/rfcs/blob/master/text/1857-stabilize-drop-order.md#tuples-structs-and-enum-variants