-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: somalier container #1487
fix: somalier container #1487
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1487 +/- ##
===========================================
+ Coverage 99.48% 99.49% +0.01%
===========================================
Files 40 40
Lines 1932 1991 +59
===========================================
+ Hits 1922 1981 +59
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! ⭐ 🌟 ⭐
I see some issues raised by sonar cloud, but I leave it up to you to decide if they are important to consider. Beyond that there's only a small need to update the https://balsamic.readthedocs.io/en/latest/bioinfo_softwares.html with the somalier version : )
Thanks. I missed the tools doc. All the issues from CodeFactor and SonarCloud are, now, fixed. |
|
Description
Updated somalier and fixed the container by updating the dependencies and fixing the versions.
[PR description]
Changed
updated somalier to 0.2.19
Fixed
Documentation
Tests
Feature Tests
Pipeline Integrity Tests
.hk
file)Clinical Genomics Stockholm
Documentation
Panel of Normal specific criteria
User Changes
Infrastructure Changes
Checklist
Important
Ensure that all checkboxes below are ticked before merging.
For Developers
For Reviewers
conditions where applicable, with satisfactory results.