Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relation_check not working #2057

Closed
moahaegglund opened this issue Oct 23, 2023 · 1 comment · Fixed by #2060
Closed

Relation_check not working #2057

moahaegglund opened this issue Oct 23, 2023 · 1 comment · Fixed by #2060
Assignees

Comments

@moahaegglund
Copy link

Describe the bug

It seems like relation_check is not performed, meaning that mip-dna does not fail the analysis when relationships aren't correct. In the validation data I've looked in the folders 200814 (version 9.0) and 20210428 (version 10.0) for case cleanshrimp and the file cleanshrimp_qc_metrics.yaml in the folder qccollect_ar contains this "relation_check: PASS". This is missing under the folder 20211104 (version 11.0).

I have sent the caseID of a case that should have failed on this in production to @jemten, not including it here.

Expected behavior
Perform the check and if needed fail analysis.

Software version (please complete the following information):

  • MIP: 11.0

Additional context
Add any other context about the problem here.

@jemten
Copy link
Collaborator

jemten commented Oct 23, 2023

Thanks for submitting. I'll have a look!

@jemten jemten self-assigned this Oct 23, 2023
@jemten jemten mentioned this issue Oct 23, 2023
6 tasks
@jemten jemten linked a pull request Oct 23, 2023 that will close this issue
6 tasks
@jemten jemten closed this as completed in 9996106 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants