Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastp #2065

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Fastp #2065

merged 8 commits into from
Feb 15, 2024

Conversation

jemten
Copy link
Collaborator

@jemten jemten commented Feb 14, 2024 •
edited
Loading

This PR adds | fixes:

  • Adds fastp as a trimming step prior to running alignment. Only for the DNA workflow

How to test:

  • Automatic and continuous test suite

Expected outcome:

  • Installation, unit and integration test suite pass

Review:

  • Code review
  • Tests pass

This version is a:

  • MAJOR - when you make incompatible API changes. If applicable record manual test results in PR header
  • MINOR - when you add functionality in a backwards compatible manner. If applicable record manual test results in PR header
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@jemten jemten marked this pull request as ready for review February 15, 2024 14:54
@jemten jemten requested review from henrikstranneheim and a team as code owners February 15, 2024 14:54
henrikstranneheim
henrikstranneheim approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Good thing we are switching soon! 👍

@jemten
Copy link
Collaborator Author

jemten commented Feb 15, 2024

Well done! Good thing we are switching soon! 👍

Indeed!

@jemten jemten merged commit 20b3d30 into develop Feb 15, 2024
9 checks passed
@jemten jemten deleted the fastp branch February 15, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikstranneheim henrikstranneheim henrikstranneheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jemten @henrikstranneheim