"record_rule = max" appears to prioritize based on max(value) rather than max(score)

[bjhall]

At least for "data_type = integer", not sure about float and string.

Minimal test vcf and rank model for testing (had to name them *.txt for github to allow them to be uploaded):

minimal.vcf.txt
minimal_rankmodel.ini.txt

If I run:
$ genmod score -i test -c minimal_rankmodel.ini.txt -r minimal.vcf.txt -o minimal.score

I get "RankResult=1" (from value 5) whereas I would expect it to be 100 (from value 4).

Same problem with "record_rule = min" btw.

[bjhall]

obviously it doesn't affect data_type=string since it has no "value"

[dnil]

Let's have a look at the code ntentions here. And make sure the models are safe either way, which I kind of guess they are.