Fix(samples endpoint) Moved join(Analysis) out of smaller functions

[Vince-janv]

Description

Currently when using both the plate_id and incomplete parameters, the following error is raised:

sqlalchemy.exc.OperationalError: (pymysql.err.OperationalError) (1066, "Not unique table/alias: 'analysis'")
[SQL: SELECT sample.status, sample.comment, sample.sex, sample.created_at, sample.id
FROM sample INNER JOIN analysis ON sample.id = analysis.sample_id INNER JOIN analysis ON sample.id = analysis.sample_id
WHERE analysis.plate_id = %(plate_id_1)s GROUP BY analysis.sample_id
HAVING count(analysis.sample_id) < %(count_1)s ORDER BY analysis.created_at, sample.created_at DESC
LIMIT %(param_1)s, %(param_2)s]
[parameters: {'plate_id_1': '120', 'count_1': 2, 'param_1': 0, 'param_2': 10}]

Changed

• Moved the join(Analysis) statement out of the smaller functions

Steps to consider while deploying

• Configuration changes:
• Documentation updates:
• Inform users by email:

Review:

• Code approved by
• Tests executed on stage by: (Document the test done with screen shots and description.)
• "Merge and deploy" approved by

This version is a:

• MAJOR - when you make incompatible API changes
• MINOR - when you add functionality in a backwards compatible manner
• PATCH - when you make backwards compatible bug fixes or documentation/instructions

[Vince-janv]

All parameters can now be used in conjuncture:

[thelander]

Looks good 👍