Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(samples endpoint) Remove duplication #71

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

Vince-janv
Copy link
Contributor

@Vince-janv Vince-janv commented Nov 9, 2022

Description

Since a completed sample has two analyses it shows up twice when searched for in the /samples endpoint, which makes usage of the endpoint confusing.

Changed

  • Samples with two analyses no longer show up twice from the /samples endpoint

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@clingen-sthlm clingen-sthlm temporarily deployed to stage November 9, 2022 13:24 Inactive
@Vince-janv
Copy link
Contributor Author

Previously:

Screenshot 2022-11-09 at 14 24 36

After change:

Screenshot 2022-11-09 at 14 24 51

@Vince-janv Vince-janv linked an issue Nov 9, 2022 that may be closed by this pull request
Copy link

@thelander thelander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Vince-janv Vince-janv merged commit 8e51a5f into main Nov 9, 2022
@Vince-janv Vince-janv deleted the fix-duplicates-samples branch November 9, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate samples returned from getSamples
3 participants