cigrid-ui-412 new column types #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested in stage and the backend seemed to allow for strings as method document + method version. Attaching screenshot: 
|
ChrOertlin
approved these changes
May 16, 2023
| op.alter_column("user", "email", existing_type=mysql.VARCHAR(length=128), nullable=False) | ||
| op.drop_index("email", table_name="user") | ||
| op.drop_index("google_id", table_name="user") | ||
| op.create_index(op.f("ix_user_email"), "user", ["email"], unique=True) |
There was a problem hiding this comment.
Just for me to understand, this makes a link between user, email and then generates an index over that?
There was a problem hiding this comment.
It creates and index for the email column in the user table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Steps to consider while deploying
Review:
This version is a: