Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete submission endpoint #137

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Delete submission endpoint #137

merged 5 commits into from
Nov 18, 2024

Conversation

northwestwitch
Copy link
Member

Description

Added

  • An endpoint that can be used to remove submissions from ClinVar, given that you have an API key and the ClinVar accession number (SCVxxxxxxx)

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@northwestwitch
Copy link
Member Author

Tested OK:

image

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94.36%. Comparing base (123ee47) to head (17202f0).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
preClinVar/main.py 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   95.30%   94.36%   -0.94%     
==========================================
  Files          11       11              
  Lines         490      497       +7     
==========================================
+ Hits          467      469       +2     
- Misses         23       28       +5     
Flag Coverage Δ
unittests 94.36% <37.50%> (-0.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch northwestwitch merged commit 3e91bd0 into main Nov 18, 2024
7 checks passed
@northwestwitch northwestwitch deleted the delete_submission_endpoint branch November 21, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants