Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4884 - enable Gens balsamic button #4885

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Sep 23, 2024

This PR adds a functionality or fixes a bug.

Gens button enabled also on cancer individuals table (if gens integration is enabled).

Testing on cg-vm1 server (Clinical Genomics Stockholm)

Prepare for testing

  1. Make sure the PR is pushed and available on Docker Hub
  2. Fist book your testing time using the Pax software available at https://pax.scilifelab.se/. The resource you are going to call dibs on is scout-stage and the server is cg-vm1.
  3. ssh <USER.NAME>@cg-vm1.scilifelab.se
  4. sudo -iu hiseq.clinical
  5. ssh localhost
  6. (optional) Find out which scout branch is currently deployed on cg-vm1: podman ps
  7. Stop the service with current deployed branch: systemctl --user stop scout.target
  8. Start the scout service with the branch to test: systemctl --user start scout@<this_branch>
  9. Make sure the branch is deployed: systemctl --user status scout.target
  10. After testing is done, repeat procedure at https://pax.scilifelab.se/, which will release the allocated resource (scout-stage) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm)

Prepare for testing

  1. ssh <USER.NAME>@hasta.scilifelab.se
  2. Book your testing time using the Pax software. us; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.
  3. (optional) Find out which scout branch is currently deployed on cg-vm1: conda activate S_scout; pip freeze | grep scout-browser
  4. Deploy the branch to test: bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
  5. Make sure the branch is deployed: us; scout --version
  6. After testing is done, repeat the paxa procedure, which will release the allocated resource (scout-stage) to be used for testing by other users.

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by CR
  • tests executed by DN

Copy link

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.77%. Comparing base (c73ea6b) to head (1803a48).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4885   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files         319      319           
  Lines       19296    19296           
=======================================
  Hits        16358    16358           
  Misses       2938     2938           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dnil dnil marked this pull request as ready for review September 23, 2024 12:24
@dnil
Copy link
Collaborator Author

dnil commented Sep 23, 2024

❌ Before: Screenshot 2024-09-23 at 14 15 23
✅ After: Screenshot 2024-09-23 at 14 19 17

@dnil dnil added the Easy label Sep 23, 2024
@dnil
Copy link
Collaborator Author

dnil commented Sep 23, 2024

Ping @mathiasbio - its on stage now, enabled for all cancer track cases as well. Is that as intended?

Copy link
Member

@northwestwitch northwestwitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! 💯

@@ -29,7 +29,7 @@
<tbody>
{% for ind in case.individuals %}
<tr {% if ind.phenotype_human == 'tumor' %} class="bg-danger-light" {% endif %}>
<td>{{ ind.display_name }}{% if gens_info.display and ind.analysis_type|upper == "WGS" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@dnil dnil merged commit c485626 into main Sep 23, 2024
27 checks passed
@mathiasbio
Copy link

Sorry for the late reply! Looks like it's working 🙏 Thank you! I don't know how this implementation works, if it will display the button even if GENS results are not uploaded. But either way it should be fine. We're planning to make this release SOON! (I keep saying this but it is true) and if the button is showing and not leading anywhere in the interim time it should be fine!

@dnil
Copy link
Collaborator Author

dnil commented Sep 26, 2024

Good, and quite agree. It will be nice when they are loaded, but reaching a "missing gens data" page in the meantime is no biggie.

There is an old issue on gens to allow api polling for case data. Feel free to work on/nudge that one if you would wish to have the buttons more adaptive.

@northwestwitch northwestwitch deleted the enable_balsamic_tga_gens branch October 10, 2024 14:33
dreamweaver-cell pushed a commit to dreamweaver-cell/scout that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants