-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4884 - enable Gens balsamic button #4885
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4885 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 319 319
Lines 19296 19296
=======================================
Hits 16358 16358
Misses 2938 2938 ☔ View full report in Codecov by Sentry. |
Ping @mathiasbio - its on stage now, enabled for all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix! 💯
@@ -29,7 +29,7 @@ | |||
<tbody> | |||
{% for ind in case.individuals %} | |||
<tr {% if ind.phenotype_human == 'tumor' %} class="bg-danger-light" {% endif %}> | |||
<td>{{ ind.display_name }}{% if gens_info.display and ind.analysis_type|upper == "WGS" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Sorry for the late reply! Looks like it's working 🙏 Thank you! I don't know how this implementation works, if it will display the button even if GENS results are not uploaded. But either way it should be fine. We're planning to make this release SOON! (I keep saying this but it is true) and if the button is showing and not leading anywhere in the interim time it should be fine! |
Good, and quite agree. It will be nice when they are loaded, but reaching a "missing gens data" page in the meantime is no biggie. There is an old issue on gens to allow api polling for case data. Feel free to work on/nudge that one if you would wish to have the buttons more adaptive. |
This PR adds a functionality or fixes a bug.
Gens button enabled also on cancer individuals table (if gens integration is enabled).
Testing on cg-vm1 server (Clinical Genomics Stockholm)
Prepare for testing
scout-stage
and the server iscg-vm1
.ssh <USER.NAME>@cg-vm1.scilifelab.se
sudo -iu hiseq.clinical
ssh localhost
podman ps
systemctl --user stop scout.target
systemctl --user start scout@<this_branch>
systemctl --user status scout.target
scout-stage
) to be used for testing by other users.Testing on hasta server (Clinical Genomics Stockholm)
Prepare for testing
ssh <USER.NAME>@hasta.scilifelab.se
us; paxa -u <user> -s hasta -r scout-stage
. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.conda activate S_scout; pip freeze | grep scout-browser
bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
us; scout --version
paxa
procedure, which will release the allocated resource (scout-stage
) to be used for testing by other users.How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: