Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5227 - update gnomAD constraint to 4.1 #5228

Merged
merged 8 commits into from
Feb 10, 2025
Merged

Fix #5227 - update gnomAD constraint to 4.1 #5228

merged 8 commits into from
Feb 10, 2025

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Feb 7, 2025

This PR adds a functionality or fixes a bug.

Screenshot 2025-02-07 at 10 29 30
Screenshot 2025-02-07 at 10 38 41

Testing on cg-vm1 server (Clinical Genomics Stockholm)

Prepare for testing

  1. Make sure the PR is pushed and available on Docker Hub
  2. Fist book your testing time using the Pax software available at https://pax.scilifelab.se/. The resource you are going to call dibs on is scout-stage and the server is cg-vm1.
  3. ssh <USER.NAME>@cg-vm1.scilifelab.se
  4. sudo -iu hiseq.clinical
  5. ssh localhost
  6. (optional) Find out which scout branch is currently deployed on cg-vm1: podman ps
  7. Stop the service with current deployed branch: systemctl --user stop scout.target
  8. Start the scout service with the branch to test: systemctl --user start scout@<this_branch>
  9. Make sure the branch is deployed: systemctl --user status scout.target
  10. After testing is done, repeat procedure at https://pax.scilifelab.se/, which will release the allocated resource (scout-stage) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm)

Prepare for testing

  1. ssh <USER.NAME>@hasta.scilifelab.se
  2. Book your testing time using the Pax software. us; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.
  3. (optional) Find out which scout branch is currently deployed on cg-vm1: conda activate S_scout; pip freeze | grep scout-browser
  4. Deploy the branch to test: bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
  5. Make sure the branch is deployed: us; scout --version
  6. After testing is done, repeat the paxa procedure, which will release the allocated resource (scout-stage) to be used for testing by other users.

How to test:

  1. note constraint values for some gene in 4.0, e.g. POT1 loss o/e avg.
  2. uv run scout download exac
  3. uv run scout update genes -f .
  4. note that the value has changed in 4.1

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by
  • tests executed by DN

@dnil dnil marked this pull request as ready for review February 7, 2025 10:13
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.42%. Comparing base (316639f) to head (76b758e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scout/commands/setup/setup_scout.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5228   +/-   ##
=======================================
  Coverage   84.42%   84.42%           
=======================================
  Files         327      327           
  Lines       19837    19837           
=======================================
  Hits        16748    16748           
  Misses       3089     3089           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@northwestwitch northwestwitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@dnil dnil merged commit dea594b into main Feb 10, 2025
26 checks passed
@dnil dnil deleted the update_constraint branch February 10, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gnomAD constraint - v4.1 is out
2 participants