Eliminate deprecation warnings in ActiveRecord 5.2 #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from Rails 5.2 passing raw SQL to methods like `order` is deprecated and in 6.0 it will be forbidden because of security concerns. When users sure that passed string is safe, they must wrap it with `Arel.sql`.
|
Will there be a new release with this fix in? |
|
@seuros do you want to do a release (it'd be your first!)? I'm not super stoked to do one with the current travis failures--they're from |
|
Yes. I will handle this release |
Closed
SMaxOwok
added a commit
to ManifoldScholar/manifold
that referenced
this pull request
Apr 3, 2019
Necessary to resolve deprecation warnings as a result of raw SQL in queries. ClosureTree/closure_tree#296
SMaxOwok
added a commit
to ManifoldScholar/manifold
that referenced
this pull request
Apr 3, 2019
Necessary to resolve deprecation warnings as a result of raw SQL in queries. ClosureTree/closure_tree#296
SMaxOwok
added a commit
to ManifoldScholar/manifold
that referenced
this pull request
Apr 4, 2019
Necessary to resolve deprecation warnings as a result of raw SQL in queries. ClosureTree/closure_tree#296
SMaxOwok
added a commit
to ManifoldScholar/manifold
that referenced
this pull request
Apr 4, 2019
Necessary to resolve deprecation warnings as a result of raw SQL in queries. ClosureTree/closure_tree#296
zdavis
pushed a commit
to ManifoldScholar/manifold
that referenced
this pull request
May 30, 2019
Necessary to resolve deprecation warnings as a result of raw SQL in queries. ClosureTree/closure_tree#296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from Rails 5.2 passing raw SQL to methods like
orderis deprecated and in 6.0 it will be forbidden because of security concerns.When users sure that passed string is safe, they must wrap it with
Arel.sql.