Call Module#module_parent instead of deprecated #parent #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anything preventing this from being merged/released? |
kbrock
reviewed
Sep 10, 2019
| @@ -32,7 +32,12 @@ def initialize(model_class, options) | |||
| end | |||
|
|
|||
| def hierarchy_class_for_model | |||
| hierarchy_class = model_class.parent.const_set(short_hierarchy_class_name, Class.new(ActiveRecord::Base)) | |||
| parent_class = if ActiveSupport.version >= Gem::Version.new('6.0.0.beta1') | |||
There was a problem hiding this comment.
may want to to_s for the comparison - it simplifies things
Also, rails 6.0 has been released, so probably want to fix that too
Suggested change
| parent_class = if ActiveSupport.version >= Gem::Version.new('6.0.0.beta1') | |
| parent_class = if ActiveSupport.version.to_s >= "6.0.0" |
grk
reviewed
Oct 16, 2019
| @@ -32,7 +32,12 @@ def initialize(model_class, options) | |||
| end | |||
|
|
|||
| def hierarchy_class_for_model | |||
| hierarchy_class = model_class.parent.const_set(short_hierarchy_class_name, Class.new(ActiveRecord::Base)) | |||
| parent_class = if ActiveSupport.version >= Gem::Version.new('6.0.0.beta1') | |||
There was a problem hiding this comment.
Could also be
Suggested change
| parent_class = if ActiveSupport.version >= Gem::Version.new('6.0.0.beta1') | |
| parent_class = if ActiveSupport::VERSION::MAJOR >= 6 |
kbrock
reviewed
Oct 17, 2019
| @@ -7,7 +7,7 @@ gem "activerecord", "~> 4.2.0" | |||
| platforms :ruby do | |||
| gem "mysql2", "< 0.5" | |||
| gem "pg", "~> 0.21" | |||
| gem "sqlite3" | |||
| gem "sqlite3", "~> 1.3", "< 1.4" | |||
There was a problem hiding this comment.
I think these gemfiles have been fixed at their source in appraisals.
Could you remove the changes to the gemfiles from this PR and ensure that the tests work for you?
| @@ -7,7 +7,7 @@ gem "activerecord", "~> 5.0.0" | |||
| platforms :ruby do | |||
| gem "mysql2" | |||
| gem "pg" | |||
| gem "sqlite3" | |||
| gem "sqlite3", "~> 1.3", "< 1.4" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To silence the deprecation warning mentioned at #346
So that it is backwards compatible with Rails versions < 6:
module_parentif ActiveSupport version >= 6.0.0.beta1parent