Skip to content

fix: hierarchy model with namespace should inherit from the superclass of basic model #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2021
Merged

fix: hierarchy model with namespace should inherit from the superclass of basic model #384

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6852654
fix: hierarchy class with namespace should inherit from the Namespace…
shawn-zhuxy Sep 15, 2021
af61b79
fix: hierarchy class with namespace should connect to the database of…
shawn-zhuxy Sep 16, 2021
6f95463
fix: hierarchy class inherit from the superclass of model class
shawn-zhuxy Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/closure_tree/support.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def initialize(model_class, options)

def hierarchy_class_for_model
parent_class = ActiveSupport::VERSION::MAJOR >= 6 ? model_class.module_parent : model_class.parent
hierarchy_class = parent_class.const_set(short_hierarchy_class_name, Class.new(ActiveRecord::Base))
hierarchy_class = parent_class.const_set(short_hierarchy_class_name, Class.new(model_class.superclass))
use_attr_accessible = use_attr_accessible?
include_forbidden_attributes_protection = include_forbidden_attributes_protection?
model_class_name = model_class.to_s
Expand Down