Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Stop participation in the challenge #189

Closed

Conversation

sanketbansal
Copy link
Contributor

@sanketbansal sanketbansal commented Jul 25, 2019

Added feature to stop participation in the challenge by the host.

Changes proposed in this pull request:

  • Added feature to stop participation in the challenge by the challenge host.

Screenshot from 2019-07-25 09-36-12

@sanketbansal sanketbansal changed the title Changes in challenge component Stop participation in the challenge Jul 25, 2019
@codecov-io
Copy link

codecov-io commented Jul 27, 2019

Codecov Report

Merging #189 into master will increase coverage by 0.39%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage    51.7%   52.09%   +0.39%     
==========================================
  Files          66       63       -3     
  Lines        3640     3411     -229     
  Branches      412      385      -27     
==========================================
- Hits         1882     1777     -105     
+ Misses       1663     1540     -123     
+ Partials       95       94       -1
Impacted Files Coverage Δ
...rc/app/components/challenge/challenge.component.ts 93.06% <14.28%> (-5.87%) ⬇️
src/app/services/auth.service.ts 24.05% <0%> (-17.08%) ⬇️
...ponents/publiclists/teamlist/teamlist.component.ts 32.25% <0%> (-5.58%) ⬇️
src/app/components/auth/auth.component.ts 90.9% <0%> (-2.43%) ⬇️
src/app/services/challenge.service.ts 44.72% <0%> (-1.44%) ⬇️
...ubliclists/teamlist/teamcard/teamcard.component.ts 62.5% <0%> (-0.84%) ⬇️
...lengelist/challengecard/challengecard.component.ts 75% <0%> (ø) ⬆️
...ts/auth/reset-password/reset-password.component.ts
...e/challengesettings/challengesettings.component.ts
...ssword-confirm/reset-password-confirm.component.ts
... and 7 more
Impacted Files Coverage Δ
...rc/app/components/challenge/challenge.component.ts 93.06% <14.28%> (-5.87%) ⬇️
src/app/services/auth.service.ts 24.05% <0%> (-17.08%) ⬇️
...ponents/publiclists/teamlist/teamlist.component.ts 32.25% <0%> (-5.58%) ⬇️
src/app/components/auth/auth.component.ts 90.9% <0%> (-2.43%) ⬇️
src/app/services/challenge.service.ts 44.72% <0%> (-1.44%) ⬇️
...ubliclists/teamlist/teamcard/teamcard.component.ts 62.5% <0%> (-0.84%) ⬇️
...lengelist/challengecard/challengecard.component.ts 75% <0%> (ø) ⬆️
...ts/auth/reset-password/reset-password.component.ts
...e/challengesettings/challengesettings.component.ts
...ssword-confirm/reset-password-confirm.component.ts
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51448e5...04d17ca. Read the comment docs.

@sanketbansal sanketbansal force-pushed the stop-participation branch 2 times, most recently from 8b32134 to 0d14b26 Compare August 11, 2019 16:33
Added feature to stop participation in the challenge by the host.
Removed margin from the check box
Removed unused changes.
@Sanji515
Copy link
Member

Sanji515 commented Jan 4, 2020

Thanks @sanketbansal for the PR, Closing this as it is opened here after resolving conflicts and with some modifications.

@Sanji515 Sanji515 closed this Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants