Showing leaderboard precision value dynamically #285
Conversation
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 50.62% 50.64% +0.02%
==========================================
Files 66 66
Lines 3771 3771
Branches 444 444
==========================================
+ Hits 1909 1910 +1
+ Misses 1767 1766 -1
Partials 95 95
Continue to review full report at Codecov.
|
| @@ -9,6 +9,7 @@ | |||
| <!-- show after authenticate user --> | |||
| <li *ngIf="authService.isAuth && !isDash"><a class="waves-effect waves-dark main-header-link" (click) ="isDash = true" routerLink="/dashboard" routerLinkActive="active">Dashboard</a></li> | |||
| <li *ngIf="authService.isAuth && isDash"><a class="waves-effect waves-dark main-header-link" routerLink="/challenges" routerLinkActive="active">All Challenges</a></li> | |||
| <li *ngIf="authService.isAuth"><a class="waves-effect waves-dark main-header-link" href="https://evalai.readthedocs.io/en/latest/" target="_blank">Docs</a></li> | |||
There was a problem hiding this comment.
I was comparing the original evalai with evalai-ngx and found that the there is a link to the documentation in the navbar of original evalai code. So, i added this line to for the same functionality in evalai-ngx too.
There was a problem hiding this comment.
Ok but this isn't related to this pr so undo it please
There was a problem hiding this comment.
Okay. I will create a different pr for this!
|
Sure! Thanks for the quick review. |
|
Sure @Sanji515 . I couldn't get the backend running from docker compose so, i compared with angularjs evali code for this commit. @Suryansh5545 has also mentioned the same. I will add the option under settings. Thanks for the quick review! |
|
Hey @Suryansh5545. Yes, i checked the issue #249 and tried that. That way i was able to run the frontend but evalai-ngx only has code for front end. So, couldn't run the backend. I was trying to make it work by running original evalai and comparing the code on it with ngx. |
|
Yesterday, i couldn't work as i had some assignments to submit. I will get back to working on this today. Sorry for the delay! |
|
@Abhi58 Can you please post a log of the error you recieve when you try to run "docker-compose up" on evalai-ngx . Also if you see the evalai-ngx repo pulls the evalai backend when you try to run it so you shouldn't require to run the original evalai repo |
|
Hi @Suryansh5545 . I am attaching the screenshots of the logs. Please look into it. So, another thing is after i run the docker compose and then ng serve,the frontend is coming up. But, i am not able to access other functionalities like creating a new host which i feel is required to solve this issue. Could you tell me how to run the backend without using docker compose? Thanks!
|
|
@Abhi58 This error is related to worker and angular so the django backend is not affected. So just let the docker-compose up compile and then go to 127.0.0.1:8888 if you see a Hello world then the backend is active and running |
|
@Abhi58 , are you following the steps given here: https://github.com/Cloud-CV/EvalAI-ngx#development-setup . You can also refer backend part here: https://github.com/Cloud-CV/EvalAI |
|
@Shekharrajak Sir for some reason currently unknown the community is having problem running the EvalAI-ngx repository. So we are using a temporary solution which will run the front end and backend on different terminals . But for some reason @Abhi58 is unable to make it work. |
Oh I see! Let me know if there is open issue regarding this or discussion happened somewhere. |
|
@Shekharrajak Sir this is the issue #249 |
Yeah! I was looking into that. Thanks! |
|
Hi, Mistakenly I had created this PR using master branch. I am closing this and created another PR with the fix: #287 |
Fix #284 :Add option to change leader-board decimal precision
Fixes #284
Changes proposed in this pull request:
-removed static leaderboard score value and added code to dynamically get the value from response obtained when a phase has been selected.
This is a work in progress PR