Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Option to change Leaderboard precision value added #290

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Abhi58
Copy link
Contributor

@Abhi58 Abhi58 commented Feb 16, 2020

Fix #284 : Add option to change leader-board decimal precision

Fixes #284

Changes proposed in this pull request:

Changes : removed static leaderboard score value and added code to dynamically get the value from response obtained when a phase has been selected.

Screenshot of the changes:

chrome-capture

@codecov-io
Copy link

Codecov Report

Merging #290 into master will decrease coverage by <.01%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
- Coverage   50.62%   50.62%   -0.01%     
==========================================
  Files          66       66              
  Lines        3771     3775       +4     
  Branches      444      445       +1     
==========================================
+ Hits         1909     1911       +2     
- Misses       1767     1769       +2     
  Partials       95       95
Impacted Files Coverage Δ
...lengeleaderboard/challengeleaderboard.component.ts 33.87% <25%> (-0.2%) ⬇️
...bliclists/challengelist/challengelist.component.ts 47.57% <0%> (+0.97%) ⬆️
Impacted Files Coverage Δ
...lengeleaderboard/challengeleaderboard.component.ts 33.87% <25%> (-0.2%) ⬇️
...bliclists/challengelist/challengelist.component.ts 47.57% <0%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d23ca...babe762. Read the comment docs.

<td id = "leaderboard_button">
<div (click)="showLeaderboardByLatestOrBest()" class="btn-switch sort-leaderboard-switch" [ngClass]="{'btn-switch--on':showLeaderboardByLatest}"
[(ngModel)]="showLeaderboardByLatest" ngDefaultControl>
<!-- <mat-chip-list>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the commented lines from here?

<div class="btn-switch-circle" [ngClass]="{'btn-switch--on':showLeaderboardByLatest}"
[(ngModel)]="showLeaderboardByLatest" ngDefaultControl></div>
</div>
<span class="w-400"> {{sortLeaderboardTextOption}}</span>
</mat-chip-list>
<!-- </mat-chip-list> -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here also

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Member

@Kajol-Kumari Kajol-Kumari Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhi58 Now you need to change here https://github.com/Cloud-CV/EvalAI-ngx/blob/master/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.html#L114 and that value that is currently hardcoded should be changed according to the value selected via the slider.

@Suryansh5545
Copy link
Member

@Abhi58 Please post a gif showing how it works also you have to add the option to change the precision in challenge settings page not the leaderboard page.

@Kajol-Kumari
Copy link
Member

@Abhi58 Please post a gif showing how it works also you have to add the option to change the precision in challenge settings page not the leaderboard page.

@Abhi58 Please look at GIF below as it will help you in better understanding regarding where you have to put the slider/input field for leaderboard precision value.

ezgif com-video-to-gif (21)

@Suryansh5545 Correct me if i am missing something.

Copy link
Member

@Sanji515 Sanji515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhi58 I don't see any API call here to update the precision value. On changing this value on the front-end it should update it on the backend.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to change leader-board decimal precision
5 participants