Option to change Leaderboard precision value added #290
Conversation
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 50.62% 50.62% -0.01%
==========================================
Files 66 66
Lines 3771 3775 +4
Branches 444 445 +1
==========================================
+ Hits 1909 1911 +2
- Misses 1767 1769 +2
Partials 95 95
Continue to review full report at Codecov.
|
| <td id = "leaderboard_button"> | ||
| <div (click)="showLeaderboardByLatestOrBest()" class="btn-switch sort-leaderboard-switch" [ngClass]="{'btn-switch--on':showLeaderboardByLatest}" | ||
| [(ngModel)]="showLeaderboardByLatest" ngDefaultControl> | ||
| <!-- <mat-chip-list> |
There was a problem hiding this comment.
Can you please remove the commented lines from here?
| <div class="btn-switch-circle" [ngClass]="{'btn-switch--on':showLeaderboardByLatest}" | ||
| [(ngModel)]="showLeaderboardByLatest" ngDefaultControl></div> | ||
| </div> | ||
| <span class="w-400"> {{sortLeaderboardTextOption}}</span> | ||
| </mat-chip-list> | ||
| <!-- </mat-chip-list> --> |
There was a problem hiding this comment.
@Abhi58 Now you need to change here https://github.com/Cloud-CV/EvalAI-ngx/blob/master/src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.html#L114 and that value that is currently hardcoded should be changed according to the value selected via the slider.
|
@Abhi58 Please post a gif showing how it works also you have to add the option to change the precision in challenge settings page not the leaderboard page. |
@Abhi58 Please look at GIF below as it will help you in better understanding regarding where you have to put the slider/input field for leaderboard precision value.
@Suryansh5545 Correct me if i am missing something. |
Fix #284 : Add option to change leader-board decimal precision
Fixes #284
Changes proposed in this pull request:
Changes : removed static leaderboard score value and added code to dynamically get the value from response obtained when a phase has been selected.
Screenshot of the changes: