-
Notifications
You must be signed in to change notification settings - Fork 61
Leaderboard decimal precision #314
base: master
Are you sure you want to change the base?
Leaderboard decimal precision #314
Conversation
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
==========================================
- Coverage 50.62% 50.52% -0.10%
==========================================
Files 66 66
Lines 3771 3784 +13
Branches 444 444
==========================================
+ Hits 1909 1912 +3
- Misses 1767 1777 +10
Partials 95 95
Continue to review full report at Codecov.
|
@Sanji515 @Shekharrajak @RishabhJain2018 please take a look at it and if any changes are required, please let me know. |
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.scss
Show resolved
Hide resolved
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts
Outdated
Show resolved
Hide resolved
@Sanji515 Can you please review this again? |
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
==========================================
- Coverage 50.16% 50.06% -0.11%
==========================================
Files 66 66
Lines 3873 3887 +14
Branches 450 450
==========================================
+ Hits 1943 1946 +3
- Misses 1836 1847 +11
Partials 94 94
Continue to review full report at Codecov.
|
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.html
Outdated
Show resolved
Hide resolved
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.scss
Outdated
Show resolved
Hide resolved
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts
Outdated
Show resolved
Hide resolved
328595c
to
043f5a5
Compare
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts
Outdated
Show resolved
Hide resolved
@Kajol-Kumari After updating the decimal precision value using the slider the leaderboard gets refreshed but still the score metric is not updating. Like if I the score is 20 and if I change the leaderboard decimal precision value to |
@Kajol-Kumari One more change 😃 The circle with the decimal precision value looks a bit large, can we make it small |
|
…leaderboard_decimal_precision
@Kajol-Kumari Please resolve the conflicts here. |
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.scss
Outdated
Show resolved
Hide resolved
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.ts
Outdated
Show resolved
Hide resolved
@Kajol-Kumari On smaller screens I don't see that circle showing leaderboard decimal precision value. Please look into it. |
@Sanji515 I had made this value hide for small and medium screen as the slider itself also shows the value. But now i changed it so that the value will appear on all screen sizes. Please check this once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for wider screen. Not sure about tablet view. I see px
in css
src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM This can be merged now 🎉
Side note: I think we can change the placing of slider in another PR to somewhere else for better look and to save some spacing.
224c7e9
to
f7a3f7d
Compare
Fixes: #284 [ Add option to change leader-board decimal precision ]
Leaderboard precision value selector slider added under
Leaderboard
tabMat-slider has the default value of 2 on load.
Selected value gets updated in the backend
GIF:
GIF showing default value and css for different screen sizes: