Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global attributes to clouddrift.datasets.mosaic() #226

Closed
selipot opened this issue Aug 10, 2023 · 0 comments · Fixed by #339
Closed

Add global attributes to clouddrift.datasets.mosaic() #226

selipot opened this issue Aug 10, 2023 · 0 comments · Fixed by #339

Comments

@selipot
Copy link
Member

selipot commented Aug 10, 2023

I would add global attributes to the output of clouddrift.datasets.mosaic(). Not sure what they would be but some info such as the doi and reference of the dataset in an acknowledgment field.

philippemiron pushed a commit to philippemiron/clouddrift that referenced this issue Dec 9, 2023
selipot pushed a commit that referenced this issue Dec 10, 2023
Co-authored-by: Philippe Miron <philippe.miron@dtn.com>
philippemiron added a commit to philippemiron/clouddrift that referenced this issue Dec 10, 2023
Co-authored-by: Philippe Miron <philippe.miron@dtn.com>
selipot added a commit that referenced this issue Dec 16, 2023
* sofar dataset

* add test

* Subset by rows and pruning examples in docstring (#338)

* Subset by rows

* Add doctring example for pruning a dataset

* Allow querying dimensions in subset

* example edit

---------

Co-authored-by: Shane Elipot <selipot@miami.edu>

* Fix #226 (#339)

Co-authored-by: Philippe Miron <philippe.miron@dtn.com>

* fix deprecation warnings in tests (#340)

* fix deprecation warnings

* remove complex warning

* ds.sizes instead of ds.dims which will eventually return only tuple of dimensions

* log zero in sphere

* wrong exception

---------

Co-authored-by: Philippe Miron <philippe.miron@dtn.com>

* Ellipse functions (#334)

* ellipse functions

* remove comment

* lint

* typo in tests

* extra return carriage

* Update clouddrift/signal.py

Co-authored-by: Milan Curcic <caomaco@gmail.com>

* better tests

* corrected tests

* version bump

* new tests

* errstate ignore

---------

Co-authored-by: Milan Curcic <caomaco@gmail.com>

* Update datasets.py

* change name

---------

Co-authored-by: Philippe Miron <philippe.miron@dtn.com>
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Shane Elipot <selipot@miami.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant