Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix date in prune #185

Merged
merged 1 commit into from
May 30, 2023
Merged

fix date in prune #185

merged 1 commit into from
May 30, 2023

Conversation

philippemiron
Copy link
Contributor

Fix #184.

@selipot selipot requested a review from milancurcic May 30, 2023 22:00
@selipot
Copy link
Member

selipot commented May 30, 2023 •
edited
Loading

Am ok to Squash and Merge this! I tested with the GDP opened as an xarray dataset with decode_times=True

milancurcic
milancurcic approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@milancurcic milancurcic merged commit ad2334c into Cloud-Drift:main May 30, 2023
@philippemiron philippemiron deleted the 184-prune-fails-when-input-is-datetime branch June 26, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milancurcic milancurcic milancurcic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prune fails when input is datetime
3 participants
@philippemiron @selipot @milancurcic