More flexible gdp adapter

[milancurcic]

Fixes #94 and #235.

[milancurcic]

CI on Ubuntu and macOS has been failing since yesterday due to segmentation fault in codecov (tests otherwise pass). Windows is OK. I haven't found anything about this from a cursory search. It could be transient or not.

@selipot unless you really want codecov to succeed, I think we can safely merge.

[philippemiron]

What happened to all the tests?

[milancurcic]

@philippemiron see #237 (comment). Codecov is crashing in CI. It started as yesterday as far as I know.

[philippemiron]

@philippemiron see #237 (comment). Codecov is crashing in CI. It started as yesterday as far as I know.

I see.. and it's passing for Windows. 😕

[milancurcic]

For once something works in Windows :)

[philippemiron]

I feel a Microsoft bias in here.. haha

[selipot]

I have been able to test the new features such as tmp_path and the testing for existing files, all good
I noticed the following issues:

• using the FTP source 2.00 the ragged array is filled typically with one drifter less than the requested n_random_id. That behavior does not exist for experimental so I think it's ok.
• I cannot create a parquet file: it requires to use to_awkward from the ragged array instance and this fails because clouddrift.raggedarray.to_akward expects "count" instead of "rowsize"

[selipot]

For some reason I can't get my environment to recognize my latest commit and test it.

• I'd like to know if it resolves the issue of not being able to generate the parquet file via awkward
• Should it be moved to another PR?

[milancurcic]

I'd say just keep it in this PR for simplicity.

[milancurcic]

I'd like to know if it resolves the issue of not being able to generate the parquet file via awkward

Hmm, works for me. What about it doesn't work for you? Is there an error message?

[milancurcic]

I cannot create a parquet file: it requires to use to_awkward from the ragged array instance and this fails because clouddrift.raggedarray.to_akward expects "count" instead of "rowsize"

@selipot A-ha, I see this now. OK, I think your commit worked, because I can write a parquet file via awkward.

[selipot]

I'd like to know if it resolves the issue of not being able to generate the parquet file via awkward

Hmm, works for me. What about it doesn't work for you? Is there an error message?

Wrote earlier: For some reason I can't get my environment to recognize my latest commit and test it.

So I am not that skilled at VS code!

[selipot]

The tests fail because of rowsize