Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdp-update #282

Merged
merged 14 commits into from
Oct 4, 2023
Merged

Gdp-update #282

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
59b6e62
add wavelet module to doc?
selipot Sep 17, 2023
4b39d15
fix the few warnings after generating the doc
Sep 17, 2023
29da4ee
lint
Sep 17, 2023
425ca31
Merge branch 'Cloud-Drift:main' into main
selipot Sep 22, 2023
4313187
version 2.01
selipot Sep 26, 2023
53895a5
update datasets.gdp1h()
selipot Sep 26, 2023
bdae72d
lint
selipot Sep 26, 2023
b02e499
move GDP_VERSION
selipot Sep 27, 2023
d70048d
file pattern change
selipot Sep 27, 2023
03c048c
fix the fix
Sep 27, 2023
5839b09
typo
Sep 27, 2023
ec34676
adjust path with experimental url
Sep 28, 2023
de02a56
actually I prefer this
Sep 28, 2023
5ee5945
forgot the default value
Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clouddrift/adapters/gdp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import urllib.request
import warnings

GDP_VERSION = "2.00"
GDP_VERSION = "2.01"

GDP_COORDS = [
"ids",
Expand Down
4 changes: 2 additions & 2 deletions clouddrift/adapters/gdp1h.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import xarray as xr


GDP_DATA_URL = "https://www.aoml.noaa.gov/ftp/pub/phod/lumpkin/hourly/v2.00/netcdf/"
GDP_DATA_URL = "https://www.aoml.noaa.gov/ftp/pub/phod/lumpkin/hourly/v2.01/netcdf/"
GDP_DATA_URL_EXPERIMENTAL = (
"https://www.aoml.noaa.gov/ftp/pub/phod/lumpkin/hourly/experimental/"
)
Expand Down Expand Up @@ -547,7 +547,7 @@ def to_raggedarray(
--------

Invoke `to_raggedarray` without any arguments to download all drifter data
from the 2.00 GDP feed:
from the 2.01 GDP feed:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make the docstring include automatically the GDP_VERSION variable here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's possible. The doc is also generated from the source code and it would have to be interpreted to get the value..


>>> from clouddrift.adapters.gdp1h import to_raggedarray
>>> ra = to_raggedarray()
Expand Down